Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 w/arch + Windows support #30

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7104554354, please use this URL for debugging.

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mikemhenry
Copy link
Contributor

11.2 CUDA builds are failing with nvcc fatal : Unsupported gpu architecture 'compute_89'

@RaulPPelaez
Copy link
Contributor

I have seen this before. The build is for CUDA 11.2, but due to the major CUDA version compat the cudatoolkit that gets installed is 11.8.
So the build script thinks it has the archs for 11.8 available but then it is getting nvcc 11.2.

One solution is to pin cuda-version.

@RaulPPelaez
Copy link
Contributor

@mikemhenry please review!

@mikemhenry
Copy link
Contributor

Looks great @RaulPPelaez thank you so much!

@mikemhenry mikemhenry merged commit c8369cd into conda-forge:main Dec 8, 2023
14 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-3_he43ec9 branch December 8, 2023 18:44
@RaulPPelaez
Copy link
Contributor

@mikemhenry I just noticed this was not actually build for CUDA 12, only CUDA 11.2 due to this skip present in the meta.yaml:

  skip: true  # [cuda_compiler_version not in ("None", "11.2")]

Should we revert this PR or open a new one on top?

@RaulPPelaez RaulPPelaez mentioned this pull request Dec 11, 2023
5 tasks
@mikemhenry
Copy link
Contributor

Ooops! We should do a new PR IMHO, I can do that

@RaulPPelaez
Copy link
Contributor

RaulPPelaez commented Dec 12, 2023

Already did, and you already merged it hehe. Its #32

@mikemhenry
Copy link
Contributor

Hahaha, okay that explains it 🙃 was very confused as soon as I pulled down the repo and couldn't find the line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants