-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for hdf5 1.14.4 (and keep 1.14.3) #152
Rebuild for hdf5 1.14.4 (and keep 1.14.3) #152
Conversation
…onda-forge-pinning 2024.12.03.09.04.35
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12159463880. Examine the logs at this URL for more detail. |
The windows test failure is discussed in h5py/h5py#2520 and is a regression in libhdf5 |
HDFGroup/hdf5#5037 is the upstream discussion to check (I see that @hmaarrfk is already in these discussions). |
I think that asking upstream to politely revert the breaking change would really help. If they do, I would gladly back port the patch and stop the dual builds. But I don’t want to patch changing behavior again. With that said. I think we are ready to go here. |
Could this pull request be merged? 🙏 |
Why? do you need 1.14.4? All packages that depend on HDF5 should be able to be run with 1.14.3. This basically introduced a change in behavior that I believe is critical to windows users, and detremental to a healthy ecosystem. I think HDF5 1.14.4/1.14.5 should be considered broken. and I totally understand why maintainers (and upstream developers) are scared to press merge. |
I'm asking "why you need it" because it blocked me a month ago, and I would like to get your packages "unstuck" too and compatible with 1.14.3 if they are not. |
@hmaarrfk some how I thought you had merge rights on this? |
@hmaarrfk I don't recall the exact details, but there was an issue installing h5py with the latest version of pytorch due to dependency conflicts. To resolve this, I rebuilt it locally and hosted it on my personal account (https://anaconda.org/jslee02/h5py/files). I had assumed that merging this PR would update the dependencies and potentially resolve the issue, but your comment suggests there may be other concerns that I wasn't aware of.. @tacaswell Thanks for merging! |
I do, but I try to use my powers sparingly and don't want to do super contentious decisions that I know are going to backfire with windows users. Everytime I see the "latest character" in a filename, somebody surprises me with a new one. Next step, emojis are going to be a requirement for our software too ^_^. I really think this should be made a stronger point to upstream that this kinda of breakage is worthy of "reverting a commit".
I have a feeling that before conda-forge/opencv-feedstock#440 got pulled in there was alot of trouble since I was trying to install latest pytorch + h5py and seeing similar errors. ps. you may have to delete your package, or move it to a "old" label, so that conda-forge's gets picked up again in case you have strict channel priority. |
Yup, I just confirmed that the new build works with the latest pytorch, and removed one in my channel. TIL, "old" label can be used in this case, thanks! |
This PR has been triggered in an effort to update hdf51144.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12140831604 - please use this URL for debugging.