Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for hdf5 1.14.4 #151

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update hdf51144.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11488800688 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 4, 2024

@jaimergp did the filesystem change on windows and making the unicode test fail?

@jaimergp
Copy link
Member

jaimergp commented Nov 4, 2024

We haven't touched that part. The two things that changed on Windows were:

  • Default to D:\ for the installation (and keep CONDA_BLD_PATH in the same drive to maximize performance). Since CONDA_BLD_PATH was already pointing to D: before that change, it shouldn't have an effect.
  • Use micromamba to provision the base install. Again, not sure why that would make a difference. Checking main, it was already using micromamba in the last commit.

The only other thing I can think of is:

  • Something changed in our Pythons. Weird that it would affect every version.
  • Something changed in the Azure VM image. More likely?
  • Upstream issue?

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 5, 2024

yeah i kinda want to rebuild hdf5 1.14.3 with newer compilers just to check these theories. thanks

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 5, 2024

I think this is the issue:

HDFGroup/hdf5#5037

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 5, 2024

Lets dicsuss conda-forge specific implications conda-forge/hdf5-feedstock#240

@hmaarrfk hmaarrfk marked this pull request as draft November 5, 2024 13:13
@jeongseok-meta
Copy link

Out of curiosity, is it acceptable to merge without updating Windows and address the issue later, possibly by creating a branch? I know this would increase complexity, but I was wondering if it's still something that can be considered.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 8, 2024

No. Not acceptable since it would create an incompatibility for downstream packages that need h5py and HDF5 on windows.

Perhaps you can elaborate on why moving forward with this migration would be important for you on the issue I’ve opened on the HDF5 feedstock.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Dec 4, 2024

Ok i think we should skip the test in #152 for 1.14.4 and 1.14.5 and merge.

Users of windows should speak up to upstream to explain the urgency of reverting their breaking fix.

@tacaswell
Copy link
Contributor

See h5py/h5py#2520 , this is a regression in libhdf5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants