-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for hdf5 1.14.4 #151
base: main
Are you sure you want to change the base?
Rebuild for hdf5 1.14.4 #151
Conversation
…nda-forge-pinning 2024.10.23.15.59.32
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jaimergp did the filesystem change on windows and making the unicode test fail? |
We haven't touched that part. The two things that changed on Windows were:
The only other thing I can think of is:
|
yeah i kinda want to rebuild hdf5 1.14.3 with newer compilers just to check these theories. thanks |
I think this is the issue: |
Lets dicsuss conda-forge specific implications conda-forge/hdf5-feedstock#240 |
Out of curiosity, is it acceptable to merge without updating Windows and address the issue later, possibly by creating a branch? I know this would increase complexity, but I was wondering if it's still something that can be considered. |
No. Not acceptable since it would create an incompatibility for downstream packages that need h5py and HDF5 on windows. Perhaps you can elaborate on why moving forward with this migration would be important for you on the issue I’ve opened on the HDF5 feedstock. |
Ok i think we should skip the test in #152 for 1.14.4 and 1.14.5 and merge. Users of windows should speak up to upstream to explain the urgency of reverting their breaking fix. |
See h5py/h5py#2520 , this is a regression in libhdf5 |
This PR has been triggered in an effort to update hdf51144.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11488800688 - please use this URL for debugging.