Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check that windows build works fine and fix build string #211

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 9, 2024

Thanks to conda-forge/conda-forge-pinning-feedstock#5736 this should fix gazebosim/gazebo-classic#3379 . Note that this will be fixed by the re-rendering, the rest of the changes just prevent future regression of this kind (and fix the build string that is an unrelated issue, regression of #208).

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro traversaro changed the title Add check that windows build work fine and fix build string Add check that windows build works fine and fix build string Apr 9, 2024
@traversaro traversaro added the automerge Merge the PR when CI passes label Apr 9, 2024
@github-actions github-actions bot merged commit 9d22908 into conda-forge:main Apr 9, 2024
12 checks passed
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gazebo installation on Windows 11 (conda-forge) gazebo==11.14.0=*_10 unsuccessful
1 participant