Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variants to permit clean co-installation with libgz-tools2 #208

Merged
merged 10 commits into from
Apr 7, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 3, 2024

We want to permit to side-by-side installation of gazebo and libgz-tools2 to facilitate migration to gz-sim, however they both install a command called gz. So, with this PR are building two different variants:

  • One called origname that has higher priority and is installed if libgz-tools2 is not installed, that uses gz as the name for the cli helper of gazebo classic. This variant can't be installed if libgz-tools2 is installed. For forward compatibility, this variant also installs a gz11 command.
  • Another variant, called gzcompatname that is co-installable with libgz-tools2, but that renames the gz commmand line tool to gz11

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [150]

@traversaro traversaro changed the title Add variants to permit co-installation with libgz-tools2 Add variants to permit clean co-installation with libgz-tools2 Apr 3, 2024
@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

The alternative name for this comes from gazebo-release/gazebo11-gz-split-release#1 . Thinking a bit more it, probably it make more sense to also install gz11 in the origname variant, so that if one wants he can always use gz11 and it will always work (at least with modern packages).

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

fyi @xela-95

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gazebo-feedstock/actions/runs/8551017099.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/gazebo-feedstock/actions/runs/8587083488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant