-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure cupy-core
can be installed in CPU-only envs
#264
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Setting this to draft as the alternative is to patch the repodata (and don't update the recipe until the next release or bug fix). |
Thank you for taking an other stab at this. I think it would help downstream projects if
|
I am still not sure why macOS is a problem. Here the relaxation makes sense, because the underlying assumption is "on the same system, if NVIDIA hardware and software are plugged in, the code will run." It's not the case for macOS, and if you are saying it is ok for "import cupy" to fail on Mac, why not just skip run:
- cupy-core # [not osx] We should not do anything that the upstream does not support, because it'd only be causing confusion for those who think "a package that's offered must be functional." It doesn't matter that we document it. Users don't read docs. Also, have you tried MLX? (#260 (comment)) |
|
Because from a packaging standpoint, anything other than a Again, I understand you aren't considering this usecase, but I expect it is quite common to have the following setup in many organizations:
|
I see you're referring to known issues like (conda/conda#8089, mamba-org/mamba#1788). Unfortunately yes this is one of the few things that However, it doesn't seem to be something that the cupy package needs to address? For example, you can
|
@jakirkham PTAL at this PR and also (conda-forge/conda-forge-repodata-patches-feedstock#715), see the above discussion. |
I understand. The maintenance burden of such packages cannot be ignored. I'll keep these 3 options as others use and comment on their usecases more and more for cupy. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/cupy-feedstock/actions/runs/8850913003. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
xref:
cupy
without explicitly requestingcuda-version
now defaults to CUDA 11.8 instead of CUDA 12 #247 (comment)This was the intended design (both in the upstream implementation and the new
cupy-core
packaging scheme). For some reason we overlooked it. Correction is made in this PR.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)