Patch cupy-core to allow it to be installed in CPU-only envs
#715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
5 tasks
|
@conda-forge/cupy this is ready Diff as generated by CI |
|
You can also achieve this by a new build on the feedstock instead of a repodata patch. This would be preferred. |
Thanks, Uwe. Interesting because in the past I was advised to do the opposite (patch the repodata if possible so as to avoid unnecessary resource usage). Anyway I did also prepare a new build (conda-forge/cupy-feedstock#264), I will proceed there. |
|
The rule of thumb is that if it only affects a single feedstock and you can solve it by a new build, then do that. If there is a new release with e.g. a compatible ABI to the old version (i.e. ABI stability is better than run_exports), then patch the repodata over an (unnecessary) migration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: conda-forge/cupy-feedstock#264 (comment)
Checklist
generate_patch_json.pyif absolutely necessary.pre-commit run -aand ensured all files pass the linting checks.python show_diff.pyand posted the output as part of the PR.