Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: soften language for the noarch: python hint, add override note, and fix a bug for v1 #2126

Merged
merged 7 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions conda_smithy/linter/hints.py
Original file line number Diff line number Diff line change
Expand Up @@ -266,21 +266,26 @@ def hint_noarch_python_use_python_min(
break
else:
hint += (
f"For the `{section_name}` section of the recipe, you should almost always use `{syntax}` "
f"for the `python` entry. "
f"\n - For the `{section_name}` section of the recipe, you should usually use `{syntax}` "
f"for the `python` entry."
)

if hint:
hint = (
(
"noarch: python recipes should almost always follow the syntax in "
"our [documentation](https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python). "
"`noarch: python` recipes should usually follow the syntax in "
beckermr marked this conversation as resolved.
Show resolved Hide resolved
"our [documentation](https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python) "
"for specifying the Python version."
)
+ hint
+ (
"You may need to override the `python_min` variable in the `conda_build_config.yaml`/`variants.yaml` "
"\n - You can override the `python_min` variable in the `conda_build_config.yaml`/`variants.yaml` "
"if the package requires a newer Python version than the currently supported minimum "
"version on `conda-forge`."
)
+ (
"\n - You will need to [rerender the feedstock](https://conda-forge.org/docs/maintainer/"
"infrastructure/#conda-forge-admin-please-rerender) after making any of these changes."
)
)
hints.append(hint)
23 changes: 23 additions & 0 deletions news/2126-adjust-noarch-py-hint.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* Changed the language in the ``noarch: python`` hint to add instructions on rerendering and use softer language. (#2126)

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>
Loading