fix: soften language for the noarch: python hint, add override note, and fix a bug for v1
#2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
changed the title
13 tasks
beckermr
changed the title
|
@conda-forge/core @maresb this is ready for review! |
maresb
reviewed
Nov 8, 2024
beckermr
changed the title
noarch: python hint, add rerendering note, and fix a bug for v1
|
@conda-forge/core this one is ready for review! |
beckermr
changed the title
noarch: python hint, add rerendering note, and fix a bug for v1noarch: python hint, add override note, and fix a bug for v1
|
OK this PR is ready to go again @conda-forge/core. I will wait through the weekend and merge on monday with a bugix release if I do not hear otherwise. |
maresb
added a commit
to maresb/conda-forge-webservices
that referenced
this pull request
Nov 9, 2024
As I explain [here](conda-forge/conda-smithy#2126 (comment)) it can be really easy to miss the distinction between hints and linting errors. (The difference is indicated in a big block of boilerplate text.) Using ℹ️ for hints and ❌ for linter errors, I hope to make this easier to understand the severity at a glance.
maresb
added a commit
to maresb/conda-forge-webservices
that referenced
this pull request
Nov 9, 2024
As I explain [here](conda-forge/conda-smithy#2126 (comment)) it can be really easy to miss the distinction between hints and linting errors. (The difference is indicated in a big block of boilerplate text.) Using ℹ️ for hints and ❌ for linter errors, I hope to make this easier to understand the severity at a glance.
maresb
added a commit
to maresb/conda-forge-webservices
that referenced
this pull request
Nov 9, 2024
As I explain [here](conda-forge/conda-smithy#2126 (comment)) it can be really easy to miss the distinction between hints and linting errors. (The difference is indicated in a big block of boilerplate text.) Using ℹ️ for hints and ❌ for linter errors, I hope to make this easier to understand the severity at a glance.
maresb
reviewed
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)Trying to address this comment from @maresb.