allow selectors in noarch_platforms recipes #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
approved these changes
Oct 26, 2022
jaimergp
reviewed
Oct 26, 2022
| ) | ||
| ) | ||
| if forge_yaml_filename: | ||
| with open(forge_yaml_filename[0], "r") as fh: |
There was a problem hiding this comment.
Shouldn't we check for noarch_platforms in all existing conda-forge.ymls, not just the first one we found? Or is it guaranteed that only one exists?
beckermr
approved these changes
Oct 26, 2022
5 tasks
|
@jaimergp, ping |
jaimergp
approved these changes
Oct 29, 2022
5 tasks
|
I’m still getting the lintong error: conda-forge/spyder-kernels-feedstock#86 (comment) Did I do something wrong? Edit: Is this the reason: #1682 (comment) |
BastianZim
reviewed
Nov 7, 2022
| @@ -913,8 +941,10 @@ def is_selector_line(line): | |||
| return False | |||
| m = sel_pat.match(line) | |||
| if m: | |||
| m.group(3) | |||
| return True | |||
| if allow_platforms and m.group(3) in ["win", "linux", "osx", "unix"]: | |||
There was a problem hiding this comment.
Shouldn't this also be the opposite? Meaning not win etc.?
This was referenced May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentry