Noarch #44
Noarch #44
Conversation
…nda-forge-pinning 2022.10.26.09.23.38
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/meta.yaml
Outdated
| - colorama # [win] | ||
| - importlib-metadata # [py<38] | ||
| - python >=3.8 | ||
| - colorama |
There was a problem hiding this comment.
@isuruf what is the best choice here? Just ship colorama on not win too or do we have a better option?
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
@conda-forge-admin, rerender |
…nda-forge-pinning 2022.10.26.13.53.24
|
The lint should go away with conda-forge/conda-smithy#1682 |
|
Wow, that's neat stuff! |
| string: "win_pyh{{ PKG_HASH }}_{{ PKG_BUILDNUM }}" # [win] | ||
| string: "unix_pyh{{ PKG_HASH }}_{{ PKG_BUILDNUM }}" # [unix] |
There was a problem hiding this comment.
Just so I can understand, was the string changed for convenience or is it serving some other purpose?
There was a problem hiding this comment.
You could get identical build strings even if you build on different platforms. I'd guess this is to guard against it.
There was a problem hiding this comment.
It's possible to avoid this issue though ( conda-forge/conda-forge.github.io#1839 (comment) )
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)