-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document microarchitecture-optimized builds #2091
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huzzah!
Sorry, a bit late to the part. In https://github.com/conda-forge/microarch-level-feedstock it is written:
So the example should also include the logic to increase the build number of packages with higher level? |
```yaml title="recipe/conda_build_config.yaml" | ||
microarch_level: # [unix and x86_64] | ||
- 1 # [unix and x86_64] | ||
- 3 # [unix and x86_64] | ||
- 4 # [unix and x86_64] | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the very recent archspec 0.2.3 now has windows support, in large part due to @isuruf's work on this. 🥳
Not sure what else is necessary to wire this up though, just tried on a fully up-to-date environment:
>conda info
[...]
virtual packages : __archspec=1=x86_64
__conda=24.1.2=0
__win=0=0
We ran into a strange bug when we recently used this feature to add microarch-optimized builds to the This didn't work for us: microarch_level: # [unix and x86_64]
- 1 # [unix and x86_64]
- 3 # [unix and x86_64]
- 4 # [unix and x86_64] ...because, weirdly, NON-x86 builds (such as Fortunately, there was an easy workaround: Always list at least one microarch_level:
- 1
- 3 # [unix and x86_64]
- 4 # [unix and x86_64] Should we modify the conda-forge docs to match? (I have not filed a bug report with |
A PR is always welcome! Maybe a note with the "gotcha" is enough:
|
It is probably not a bug, but the (IMO, unfortunate) feature of |
…t one microarch_level, to avoid a bug in conda-build As described here: conda-forge#2091 (comment)
PR Checklist:
docs/
, you have added it to the sidebar indocs/sidebar.json
We talked about this in today's conda community meeting so let's get add it to the shiny docs :D Preview link: https://deploy-preview-2091--conda-forge-previews.netlify.app/docs/maintainer/knowledge_base/#microarch
cc @mbargull