-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CasADi to 3.6.6 and enable fatrop dependency on Linux #115
Update CasADi to 3.6.6 and enable fatrop dependency on Linux #115
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.08.28.17.44.23
I see that the second patch is failing to apply. CasADi changed the line from |
Also, we had fixed the first patch upstream, so it shouldn't be needed either: casadi/casadi#3759 |
Sorry, I am not sure I am following, it seems that https://github.com/conda-forge-admin/casadi-feedstock/blob/conda_forge_admin_114/recipe/patches/0001-Modernize-Python-find_package.patch is not an overlap of casadi/casadi#3759, or I am missing something? |
For reference, this casadi/casadi@3a30c9e, casadi/casadi#3724 and casadi/casadi#3723 are the related pointers. From what I understand we can probably just drop the patch at all. |
@agriyakhetarpal for the future, if you depend on casadi and you are interested in being an additional mantainer for the feedstock to reduce the bus factor, feel free to add yourself, thanks! |
Hi @traversaro, yes, patch 0001 wasn't an overlap of casadi/casadi#3759 – I might not have looked at the entire patch, sorry. The PR fixed the issue where the Python include directory was being searched for by the
Sure, this makes sense to me!
I'd love to be an additional maintainer – thanks for the offer! I will say that I don't fully understand the CasADi build procedure in depth, but I'll provide a helping hand to you and other maintainers wherever I can. I'll trigger a bot PR for this. As for the failing Linux builds here, the location of |
Thanks, I proposed a fix upstream in casadi/casadi#3832 . |
@agriyakhetarpal feel free to check the PR, as far as I can see I think it is ready for merge. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Thanks for upstreaming it! |
Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #114.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!