Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to CasADi 3.6.6? #114

Closed
agriyakhetarpal opened this issue Aug 28, 2024 · 7 comments
Closed

Bump to CasADi 3.6.6? #114

agriyakhetarpal opened this issue Aug 28, 2024 · 7 comments
Labels

Comments

@agriyakhetarpal
Copy link
Member

Comment:

Hi there! CasADi has released a fairly new 3.6.6 release, but I didn't notice any automated PRs for updating the version. I just wanted to reach out in case there has been a problem with the builds and, if there isn't, whether a release could be triggered manually through this feedstock. Thank you!

I can do this manually by opening an issue with @conda-forge-admin, please update version, but it's usually better if the recipe maintainers do that first :)

Additional context: We are updating to CasADi 3.6.6 for both our build-time and run-time dependency as we usually do when nearing a release, and I always check if the same versions for our dependencies are available on PyPI and conda-forge.


xref: pybamm-team/PyBaMM#4391

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I just wanted to let you know that I started a version update in #115.

@agriyakhetarpal
Copy link
Member Author

Oh, I added the backticks thinking that the bot would not be pinged if I did so – haha

@traversaro
Copy link
Contributor

Hello @agriyakhetarpal, thanks for raising the issue. Sorry I was away last week and I did not see this issue. I am indeed not sure why the automatic update does not work in casadi, but I never looked into it. CasADi 3.6.6 has some nice new features that I was interested in enabling, see #112 . It is ok to wait for 1/2 days so I can look into enabling the features, or you prefer that we releaze 3.6.6 as soon as possible and then enable the additional features later?

@agriyakhetarpal
Copy link
Member Author

No worries, @traversaro! For an automatic update, I'm not sure why it doesn't work (or maybe it was disabled manually), but if you wish, you may enable the "automerge" feature to let the bot merge version update PRs if the tests pass – that might bring it back. I do not mind the delay at all, absolutely, please continue with #115 if it's easy enough to enable BLASFEO.

@traversaro
Copy link
Contributor

For an automatic update, I'm not sure why it doesn't work (or maybe it was disabled manually), but if you wish, you may enable the "automerge" feature to let the bot merge version update PRs if the tests pass – that might bring it back.

Unfortunately casadi does not have a lot of tests (either C++ or Python) that runs in the recipe, so to be honest I am not super-confident about automatically merging the version updates, I prefer always to double check manually in some downstream projects that instead have quite some tests using casadi, especially given casadi releases are not super-frequent.

@agriyakhetarpal
Copy link
Member Author

Yes, that's quite reasonable – thanks for the explanation! We could add a few tests to the recipe if needed, but manually checking has its own merits.

@traversaro
Copy link
Contributor

Fixed by #115 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants