Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master performance: 264 build new instances from a base image; improve multi user usage #329

Merged
merged 1 commit into from
May 31, 2023

Conversation

daniwe4
Copy link
Member

@daniwe4 daniwe4 commented May 24, 2023

Doil now builds on the first create call a base image. This image is the template for following instances. This will minimize the build time for round about 3 minutes.

Debian is now pinned to 11 in all docker files.

Multi User Support

If you add a new doil user, doil also create a .config/composer folder. This is necessary for mounting it into the container.

Doil create checks for an .ssh folder in your home directory.

Doil forbids global instances below the home directory.

Doil adds or append a .gitconfig file for new users with safe directories for each global instance.

@daniwe4 daniwe4 requested a review from tbongers-cat May 24, 2023 13:07
@daniwe4 daniwe4 added bug Something isn't working improvement New feature or request review labels May 24, 2023
@daniwe4 daniwe4 added this to the Performance milestone May 24, 2023
@daniwe4 daniwe4 linked an issue May 24, 2023 that may be closed by this pull request
Copy link
Contributor

@tbongers-cat tbongers-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As always, just some small notes.

README.md Outdated Show resolved Hide resolved
app/src/Commands/Instances/CreateCommand.php Show resolved Hide resolved
app/src/Lib/Docker/DockerShell.php Outdated Show resolved Hide resolved
app/src/Lib/Logger/LoggerFactory.php Show resolved Hide resolved
multi user usage

Doil now builds on the first create call a base image. This image is the
template for following instances. Tihs will minimize the build time for round
about 3 minutes.

Multi User Support

If you add a new doil user, doil also create a .config/composer folder.
This is necessary for mounting it into the container.

Doil create checks for an .ssh folder in your home directory.

Doil forbids global instances below the home directory.

Doil adds or append a gitconfig file with safe directories for each
global instance.
@tbongers-cat tbongers-cat merged commit 2261d68 into conceptsandtraining:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement New feature or request review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use same docker-image for all instances
2 participants