Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same docker-image for all instances #264

Closed
klees opened this issue Dec 16, 2022 · 0 comments · Fixed by #329
Closed

Use same docker-image for all instances #264

klees opened this issue Dec 16, 2022 · 0 comments · Fixed by #329
Assignees
@daniwe4 @tbongers-cat
Labels
bug Something isn't working improvement New feature or request review
Milestone
Performance

Comments

@klees
Copy link
Member

klees commented Dec 16, 2022

Currently, AFAIK, we rebuild a new minion image for every new instance we create. I think we could greatly improve creation speed of the instances when we only have one image for all containers. That image could be build on the installation of doil or when it is first required.

This will also create an interesting pathway for a centralized update of all instances.
@daniwe4 daniwe4 added this to the Doil-Into-Container milestone Dec 16, 2022
@daniwe4 daniwe4 self-assigned this Dec 16, 2022
@daniwe4 daniwe4 added the improvement New feature or request label Dec 16, 2022
@daniwe4 daniwe4 linked a pull request May 24, 2023 that will close this issue
master performance: 264 build new instances from a base image; improve multi user usage #329
Merged
@daniwe4 daniwe4 added bug Something isn't working review labels May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniwe4 daniwe4

@tbongers-cat tbongers-cat

Labels
bug Something isn't working improvement New feature or request review
Projects
None yet
Milestone
Performance
Development

Successfully merging a pull request may close this issue.

master performance: 264 build new instances from a base image; improve multi user usage daniwe4/doil
3 participants
@klees @daniwe4 @tbongers-cat