Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set_property for boost #8110

Closed
wants to merge 1 commit into from
Closed

Use set_property for boost #8110

wants to merge 1 commit into from

Conversation

db4
Copy link
Contributor

@db4 db4 commented Nov 19, 2021

Specify library name and version: boost


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Nov 19, 2021

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (6a867337512e89e71b5ccb405e10dfd494072300):

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 19, 2021

If I understand conan-io/conan#8533 (comment), we should avoid to move to set_property() in CCI for the moment.

@db4
Copy link
Contributor Author

db4 commented Nov 20, 2021

If I understand conan-io/conan#8533 (comment), we should avoid to move to set_property() in CCI for the moment.

You may be right but

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 20, 2021

there are many PRs already merged that add set_propery to CCI. e.g. openssl-3.x.x: Migrating names and build_modules to set_property format #8059 Use set_property for libcurl #8010 etc.

It was before conan-io/conan#8533 (comment)

conan 1.42.x makes my recipes without set_property just unusable with CMakeDeps generator. What can be done right now? I understand CMakeDeps is experimental but breaking everything by releasing the next version of Conan is too much.

Yes, here is the issue: conan-io/conan#9943.

Due to conan-io/conan#9943 and unstability of set_property() (conan-io/conan#8533 (comment)), there is no way support both cmake_find_package_* and CMakeDeps generators in a reliable way.

@db4
Copy link
Contributor Author

db4 commented Nov 20, 2021

@SpaceIm your point is taken. So what do now: just close the PR or live it open until better times arrive?

@madebr
Copy link
Contributor

madebr commented Nov 20, 2021

I would close it.
There will be a point in the not-so-distant-future where we will have to modify all recipes to support conan 2.0.

@db4 db4 closed this Nov 21, 2021
@db4 db4 deleted the boost branch November 21, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants