Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set_property for libcurl #8010

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Use set_property for libcurl #8010

merged 3 commits into from
Nov 12, 2021

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Nov 10, 2021 •
edited
Loading

Simplify! Simplify!

Specify library name and version: libcurl/any

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@uilianries
Use set_property for libcurl
ec7582e 
Signed-off-by: Uilian Ries <[email protected]>
@ghost
Copy link

ghost commented Nov 10, 2021

I detected other pull requests that are modifying libcurl/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Nov 10, 2021
Closed
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries closed this Nov 10, 2021
@uilianries uilianries reopened this Nov 10, 2021
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries closed this Nov 10, 2021
@uilianries uilianries reopened this Nov 10, 2021
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries closed this Nov 10, 2021
@uilianries uilianries reopened this Nov 10, 2021
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Nov 11, 2021
Open
SpaceIm
SpaceIm previously approved these changes Nov 11, 2021
View reviewed changes
@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 11, 2021

Bump required_conan_version to 1.36.0 please.

SSE4
SSE4 previously approved these changes Nov 11, 2021
View reviewed changes
@uilianries
libcurl requires conan 1.36
0f0d19a 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries dismissed stale reviews from SSE4 and SpaceIm via 0f0d19a November 11, 2021 13:01
@uilianries
Copy link
Member Author

Bump required_conan_version to 1.36.0 please.

Done

@conan-center-bot
Copy link
Collaborator

All green in build 6 (0f0d19a0bee15440273f16e76d45540f86e566eb):

  • libcurl/7.79.0@:
    All packages built successfully! (All logs)

  • libcurl/7.78.0@:
    All packages built successfully! (All logs)

  • libcurl/7.79.1@:
    All packages built successfully! (All logs)

  • libcurl/7.77.0@:
    All packages built successfully! (All logs)

  • libcurl/7.76.0@:
    All packages built successfully! (All logs)

  • libcurl/7.75.0@:
    All packages built successfully! (All logs)

  • libcurl/7.73.0@:
    All packages built successfully! (All logs)

  • libcurl/7.71.0@:
    All packages built successfully! (All logs)

  • libcurl/7.69.1@:
    All packages built successfully! (All logs)

  • libcurl/7.68.0@:
    All packages built successfully! (All logs)

  • libcurl/7.67.0@:
    All packages built successfully! (All logs)

  • libcurl/7.70.0@:
    All packages built successfully! (All logs)

  • libcurl/7.74.0@:
    All packages built successfully! (All logs)

  • libcurl/7.72.0@:
    All packages built successfully! (All logs)

  • libcurl/7.71.1@:
    All packages built successfully! (All logs)

  • libcurl/7.66.0@:
    All packages built successfully! (All logs)

  • libcurl/7.64.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 72a25f6 into conan-io:master Nov 12, 2021
@Croydon Croydon deleted the libcurl/properties branch November 12, 2021 17:46
@db4 db4 mentioned this pull request Nov 20, 2021
Closed
4 tasks
ivanvurbanov pushed a commit to ivanvurbanov/conan-center-index that referenced this pull request Dec 2, 2021
@uilianries @Croydon @ivanvurbanov
(conan-io#8010) Use set_property for libcurl
c9a922f 
* Use set_property for libcurl

Signed-off-by: Uilian Ries <[email protected]>

* Update recipes/libcurl/all/conanfile.py

Co-authored-by: Michael Keck <[email protected]>

* libcurl requires conan 1.36

Signed-off-by: Uilian Ries <[email protected]>

Co-authored-by: Michael Keck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm approved these changes

@Croydon Croydon Croydon approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uilianries @conan-center-bot @SpaceIm @SSE4 @Croydon