Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsonnet/0.17.0 #6099

Merged
merged 23 commits into from
Aug 13, 2021
Merged

Conversation

vcampmany
Copy link
Contributor

@vcampmany vcampmany commented Jun 29, 2021

Specify library name and version: jsonnet/0.17.0

jsonnet is a data templating language based on json: https://jsonnet.org


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, please, take a look on my review

recipes/jsonnet/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Outdated Show resolved Hide resolved
recipes/jsonnet/all/patches/fix-cpp-static-lib.patch Outdated Show resolved Hide resolved
recipes/jsonnet/all/conanfile.py Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

if (!j.init()) {
return 1;
}
std::cout << jsonnet::Jsonnet::version() << "\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::cout << jsonnet::Jsonnet::version() << "\n";
std::cout << jsonnet::Jsonnet::version() << "\n";

It's not available for GCC5 + libstdc++. Only works with libstdc++11

Besides that, both libjsonnet++.so and libjsonnet.so require libstdc++

ldd lib/libjsonnet.so
linux-vdso.so.1 => (0x00007ffde2908000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f8b93523000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f8b9321a000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f8b93004000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f8b92c3a000)
/lib64/ld-linux-x86-64.so.2 (0x00007f8b93b75000)

ldd lib/libjsonnet++.so
linux-vdso.so.1 => (0x00007ffc61d7f000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fa4dc271000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fa4dc05b000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fa4dbc91000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fa4db988000)
/lib64/ld-linux-x86-64.so.2 (0x00007fa4dc7f7000)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly is not available? I don't see what have you changed in your suggestion

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

if tools.cross_building(self, skip_x64_x86=True):
raise ConanInvalidConfiguration("jsonnet does not support cross building")

if self.settings.compiler in ["clang", "apple-clang"] and self.settings.compiler.libcxx != "libstdc++":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

Comment on lines 42 to 48
raise ConanInvalidConfiguration("jsonnet does not support cross building")

if self.settings.compiler in ["clang", "apple-clang"] and self.settings.compiler.libcxx != "libstdc++":
raise ConanInvalidConfiguration("jsonnet {} package requires libstdc++".
format(self.settings.compiler))

if self.settings.compiler.cppstd:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ConanInvalidConfiguration("jsonnet does not support cross building")
if self.settings.compiler in ["clang", "apple-clang"] and self.settings.compiler.libcxx != "libstdc++":
raise ConanInvalidConfiguration("jsonnet {} package requires libstdc++".
format(self.settings.compiler))
if self.settings.compiler.cppstd:
raise ConanInvalidConfiguration("jsonnet does not support cross building")
if self.settings.compiler.cppstd:

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor

madebr commented Aug 11, 2021

I just tested with gcc 5 and clang 3.9, and it worked flawlessly.

To trigger c3i (CI), please close this pr, wait 10 seconds and re-open it.

@vcampmany vcampmany closed this Aug 11, 2021
@vcampmany vcampmany reopened this Aug 11, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 18 (d3a2f05d266e56b9c7b38510ca02b3d080f65420):

  • jsonnet/0.17.0@:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants