-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsonnet/0.17.0 #6099
Add jsonnet/0.17.0 #6099
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bbd146c
to
c3eca00
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, please, take a look on my review
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Patch added to fix the include path when not working with the json.hpp header in thirdparty directory.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
if (!j.init()) { | ||
return 1; | ||
} | ||
std::cout << jsonnet::Jsonnet::version() << "\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::cout << jsonnet::Jsonnet::version() << "\n"; | |
std::cout << jsonnet::Jsonnet::version() << "\n"; |
It's not available for GCC5 + libstdc++. Only works with libstdc++11
Besides that, both libjsonnet++.so and libjsonnet.so require libstdc++
ldd lib/libjsonnet.so
linux-vdso.so.1 => (0x00007ffde2908000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f8b93523000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f8b9321a000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f8b93004000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f8b92c3a000)
/lib64/ld-linux-x86-64.so.2 (0x00007f8b93b75000)
ldd lib/libjsonnet++.so
linux-vdso.so.1 => (0x00007ffc61d7f000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fa4dc271000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fa4dc05b000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fa4dbc91000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fa4db988000)
/lib64/ld-linux-x86-64.so.2 (0x00007fa4dc7f7000)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly is not available? I don't see what have you changed in your suggestion
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/jsonnet/all/conanfile.py
Outdated
if tools.cross_building(self, skip_x64_x86=True): | ||
raise ConanInvalidConfiguration("jsonnet does not support cross building") | ||
|
||
if self.settings.compiler in ["clang", "apple-clang"] and self.settings.compiler.libcxx != "libstdc++": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed
recipes/jsonnet/all/conanfile.py
Outdated
raise ConanInvalidConfiguration("jsonnet does not support cross building") | ||
|
||
if self.settings.compiler in ["clang", "apple-clang"] and self.settings.compiler.libcxx != "libstdc++": | ||
raise ConanInvalidConfiguration("jsonnet {} package requires libstdc++". | ||
format(self.settings.compiler)) | ||
|
||
if self.settings.compiler.cppstd: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ConanInvalidConfiguration("jsonnet does not support cross building") | |
if self.settings.compiler in ["clang", "apple-clang"] and self.settings.compiler.libcxx != "libstdc++": | |
raise ConanInvalidConfiguration("jsonnet {} package requires libstdc++". | |
format(self.settings.compiler)) | |
if self.settings.compiler.cppstd: | |
raise ConanInvalidConfiguration("jsonnet does not support cross building") | |
if self.settings.compiler.cppstd: |
Co-authored-by: Anonymous Maarten <[email protected]>
This comment has been minimized.
This comment has been minimized.
I just tested with gcc 5 and clang 3.9, and it worked flawlessly. To trigger c3i (CI), please close this pr, wait 10 seconds and re-open it. |
This comment has been minimized.
This comment has been minimized.
All green in build 18 (
|
Specify library name and version: jsonnet/0.17.0
jsonnet is a data templating language based on json: https://jsonnet.org
conan-center hook activated.