Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsonnet/0.17.0 #6099
Add jsonnet/0.17.0 #6099
Changes from 10 commits
c3eca00
12b9109
82b3ac7
ec5f74d
6bb9da8
5933a01
f45be40
435308f
3dfa2d2
66f90ee
7f5ffd6
0183af9
4a9b4b4
1202de5
62ef293
0d68d9f
eeca19a
e4c3fb2
dda46ba
48612b0
8b36e74
280eda8
d3a2f05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not available for GCC5 + libstdc++. Only works with libstdc++11
Besides that, both libjsonnet++.so and libjsonnet.so require libstdc++
ldd lib/libjsonnet.so
linux-vdso.so.1 => (0x00007ffde2908000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f8b93523000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f8b9321a000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f8b93004000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f8b92c3a000)
/lib64/ld-linux-x86-64.so.2 (0x00007f8b93b75000)
ldd lib/libjsonnet++.so
linux-vdso.so.1 => (0x00007ffc61d7f000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fa4dc271000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fa4dc05b000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fa4dbc91000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fa4db988000)
/lib64/ld-linux-x86-64.so.2 (0x00007fa4dc7f7000)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly is not available? I don't see what have you changed in your suggestion