libarchive: add 3.5.1 + bump deps + cache cmake + del fPIC if shared + minor cosmetic changes #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prince-chrismc
previously approved these changes
Jan 12, 2021
|
@SpaceIm You can back us VS 2019 build again, if you want. :-) |
|
Some configurations of 'libarchive/3.4.0' failed in build 1 (
|
|
@dmn-star, thanks I'll add a patch |
SpaceIm
dismissed stale reviews from prince-chrismc and mathbunnyru
via
8b78e2f
|
And, to be 100% done with this recipe, you might want to add versions 3.5.0 and 3.5.1 :) |
|
Only 3.5.1 eventually. There are no significant modifications between 3.4.3 and 3.5.1 in build files, so I guess I can try. |
|
Agree with 3.5.1 only 👍 |
SpaceIm
changed the title
mathbunnyru
previously approved these changes
Jan 12, 2021
lib/cmake and cmake folders are not installed
prince-chrismc
previously approved these changes
Jan 12, 2021
mathbunnyru
previously approved these changes
Jan 12, 2021
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
easier to see if all options are covered
This was referenced Jan 13, 2021
|
All green in build 6 (
|
SpaceIm
dismissed stale reviews from mathbunnyru and prince-chrismc
via
8cf68f5
|
All green in build 7 (
|
mathbunnyru
approved these changes
Jan 13, 2021
theirix
approved these changes
Jan 13, 2021
dmn-star
approved these changes
Jan 13, 2021
SSE4
approved these changes
Jan 13, 2021
prince-chrismc
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libarchive/all
conan-center hook activated.