[fix hooks] libarchive #3778

danimtb · 2020-12-03T13:20:51Z

Specify library name and version: libarchive/all

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-12-03T13:42:52Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-12-03T14:02:59Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-12-03T15:22:15Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-12-03T18:24:31Z

Some configurations of 'libarchive/3.4.0' failed in build 4 (144802bfd747932c51602dd8d3a5a1ed75e4e37c):

Windows x86_64, Debug, Visual Studio 16, MTd. Options: libarchive:shared-False
Access to all the logs

danimtb · 2020-12-15T14:29:22Z

🤔 I tried this configuration locally and it worked for me... any clue?

danimtb · 2020-12-15T15:08:45Z

This is the error https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4061?view=msvc-160 but I don't why it fails in the CI but not in my machine. Maybe it is due to the version of the compiler?

uilianries · 2020-12-15T15:14:01Z

I'm on Windows right now, lemme try to reproduce it.

conan-center-bot · 2020-12-15T15:15:27Z

Some configurations of 'libarchive/3.4.0' failed in build 5 (144802bfd747932c51602dd8d3a5a1ed75e4e37c):

Windows x86_64, Debug, Visual Studio 16, MTd. Options: libarchive:shared-False
Access to all the logs

uilianries · 2020-12-15T15:24:32Z

My version is a bit older, but I can reproduce it:

libarchive/3.4.0: Folder: C:\Users\uilia\.conan\data\libarchive\3.4.0\_\_\export
libarchive/3.4.0: Exported revision: e1dbeefba98103fa6122b58204de7f8e
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=Visual Studio
compiler.runtime=MTd
compiler.version=16
os=Windows
os_build=Windows
[options]
[build_requires]
[env]

...

libarchive/3.4.0: Calling build()
-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.19041.
-- The C compiler identification is MSVC 19.27.29111.0
-- The CXX compiler identification is MSVC 19.27.29111.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.27.29110/bin/Hostx64/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done

...

C:\Users\uilia\.conan\data\libarchive\3.4.0\_\_\build\d78f64a6ae7b5e68fbc1e982868cb58c2031c65d\source_subfolder\libarchive\archive_read_support_format_warc.c(344,2): error C4061: enumerator 'WT_NONE' in switch of enum 'warc_type_t'
is not explicitly handled by a case label [C:\Users\uilia\.conan\data\libarchive\3.4.0\_\_\build\d78f64a6ae7b5e68fbc1e982868cb58c2031c65d\build_subfolder\source_subfolder\libarchive\archive_static.vcxproj]
C:\Users\uilia\.conan\data\libarchive\3.4.0\_\_\build\d78f64a6ae7b5e68fbc1e982868cb58c2031c65d\source_subfolder\libarchive\archive_read_support_format_warc.c(75): message : see declaration of 'warc_type_t' [C:\Users\uilia\.conan\dat a\libarchive\3.4.0\_\_\build\d78f64a6ae7b5e68fbc1e982868cb58c2031c65d\build_subfolder\source_subfolder\libarchive\archive_static.vcxproj]

uilianries · 2020-12-15T15:30:23Z

@danimtb It's a libarchive bug: libarchive/libarchive#1395

libarchive 3.4.0 doesn't support that profile, but 3.5.0 supports according that fix.

danimtb · 2020-12-15T16:01:08Z

thanks for the look into! Indeed it seems a bug from the library, but why it does not raise in my machine?

This is my setup reported by CMake:

-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.19042.
-- The C compiler identification is MSVC 19.25.28614.0
-- The CXX compiler identification is MSVC 19.25.28614.0

uilianries · 2020-12-15T16:19:27Z

According to this discussion, it's a limitation with v142 toolset

recipes/libarchive/all/conanfile.py

conan-center-bot · 2020-12-16T15:21:26Z

Some configurations of 'libarchive/3.4.0' failed in build 6 (38db1a76eeaf30ebf674c86288ab84bc077cfcb1):

Windows x86_64, Release, Visual Studio 16, MT. Options: libarchive:shared-False
Access to all the logs

uilianries · 2020-12-17T20:56:07Z

Okay, our CI is not running Conan 1.32.0. It's blocked.

mathbunnyru · 2021-01-07T23:07:25Z

@danimtb should work well now (https://github.com/conan-io/conan-center-index/blob/master/docs/changelog.md#29-december-2020---1718-cet)
Could you please retrigger the CI?

recipes/libarchive/all/conanfile.py

conan-center-bot · 2021-01-08T14:17:46Z

Some configurations of 'libarchive/3.4.0' failed in build 7 (38db1a76eeaf30ebf674c86288ab84bc077cfcb1):

Windows x86_64, Release, Visual Studio 16, MT. Options: libarchive:shared-False
Access to all the logs

conan-center-bot · 2021-01-11T09:15:28Z

Some configurations of 'libarchive/3.4.0' failed in build 8 (38db1a76eeaf30ebf674c86288ab84bc077cfcb1):

Windows x86_64, Release, Visual Studio 16, MT. Options: libarchive:shared-False
Access to all the logs

conan-center-bot · 2021-01-12T13:31:36Z

All green in build 9 (bcee037159da07b338aa64bcb48ff82973dcf9e0)! 😊

libarchive/3.4.0: Generated 80 packages (+ 1 invalid config from build()). All logs here
libarchive/3.4.3: Generated 88 packages. All logs here

SpaceIm · 2021-01-12T15:55:00Z

@danimtb Could you take advantage of this PR to bump dependencies, cache cmake and delete fPIC if shared please? I could modify this in another PR, but it would be a pity to generate another revision just for that.

    def requirements(self):
        self.requires("zlib/1.2.11")
        if self.options.with_bzip2:
            self.requires("bzip2/1.0.8")
        if self.options.with_openssl:
            self.requires("openssl/1.1.1d") # => 1.1.1i
        if self.options.with_lz4:
            self.requires("lz4/1.9.2") # => 1.9.3
        if self.options.with_zstd:
            self.requires("zstd/1.4.3") # => 1.4.8
        if self.options.with_lzma:
            self.requires("xz_utils/5.2.4") # => 5.2.5
        if self.options.with_libxml2:
            self.requires("libxml2/2.9.9") # => 2.9.10
        if self.options.with_expat:
            self.requires("expat/2.2.7") # => 2.2.10
        if self.options.with_iconv:
            self.requires("libiconv/1.15") # => 1.16
        if self.options.with_pcreposix:
            self.requires("pcre/8.41") # => 8.44
        # TODO: deps not covered yet: cng, nettle, libb2

mathbunnyru · 2021-01-12T16:08:31Z

@SpaceIm I would like it to be done it in another review. I do think that CI is not stable for this recipe, so it would be better to merge what already works.

danimtb · 2021-01-12T16:11:46Z

Agree with @mathbunnyru, I prefer to have this merged and stick to the initial goal of the PR

SpaceIm

Ok so let's this PR get merged quickly

dmn-star · 2021-01-12T20:38:59Z

This is the line SET(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /we4061") in libarchive CMakeList.txt that treats the harmless C4061 warning as an error.

You can simple patch this line out to get libarchive compiled on VS 2019 again.

[fix hooks] libarchive

144802b

conan-center-bot added the Unexpected Error label Dec 3, 2020

ericLemanissier previously approved these changes Dec 3, 2020

View reviewed changes

Croydon previously approved these changes Dec 3, 2020

View reviewed changes

uilianries closed this Dec 3, 2020

uilianries reopened this Dec 3, 2020

uilianries previously approved these changes Dec 3, 2020

View reviewed changes

conan-center-bot added Failed and removed Unexpected Error labels Dec 3, 2020

add invalid configuration

38db1a7

danimtb dismissed stale reviews from uilianries, Croydon, and ericLemanissier via 38db1a7 December 16, 2020 14:46

uilianries reviewed Dec 16, 2020

View reviewed changes

recipes/libarchive/all/conanfile.py Show resolved Hide resolved

This was referenced Jan 7, 2021

[service] Potentially conflicting recipes #3571

Closed

[libarchive] fix hooks and conventions #4141

Closed

uilianries closed this Jan 8, 2021

uilianries reopened this Jan 8, 2021

mathbunnyru suggested changes Jan 8, 2021

View reviewed changes

recipes/libarchive/all/conanfile.py Show resolved Hide resolved

This was referenced Jan 11, 2021

[Conan v1] Recipe Export Check #2232

Closed

[service] Windows x86_64, Release, Visual Studio 16, MT is misbehaving #4214

Closed

ericLemanissier mentioned this pull request Jan 12, 2021

[service] CI situation #4221

Closed

Update conanfile.py

bcee037

mathbunnyru approved these changes Jan 12, 2021

View reviewed changes

conan-center-bot removed the Failed label Jan 12, 2021

github-actions bot mentioned this pull request Jan 12, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc approved these changes Jan 12, 2021

View reviewed changes

danimtb requested a review from uilianries January 12, 2021 15:41

uilianries approved these changes Jan 12, 2021

View reviewed changes

SpaceIm approved these changes Jan 12, 2021

View reviewed changes

SSE4 approved these changes Jan 12, 2021

View reviewed changes

conan-center-bot merged commit 520dd7d into conan-io:master Jan 12, 2021

dmn-star mentioned this pull request Jan 12, 2021

libarchive: add 3.5.1 + bump deps + cache cmake + del fPIC if shared + minor cosmetic changes #4229

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix hooks] libarchive #3778

[fix hooks] libarchive #3778

danimtb commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

danimtb commented Dec 15, 2020

danimtb commented Dec 15, 2020

uilianries commented Dec 15, 2020

conan-center-bot commented Dec 15, 2020

uilianries commented Dec 15, 2020

uilianries commented Dec 15, 2020

danimtb commented Dec 15, 2020

uilianries commented Dec 15, 2020

conan-center-bot commented Dec 16, 2020

uilianries commented Dec 17, 2020

mathbunnyru commented Jan 7, 2021

conan-center-bot commented Jan 8, 2021

conan-center-bot commented Jan 11, 2021

conan-center-bot commented Jan 12, 2021

SpaceIm commented Jan 12, 2021 •

edited

Loading

mathbunnyru commented Jan 12, 2021

danimtb commented Jan 12, 2021

SpaceIm left a comment

dmn-star commented Jan 12, 2021

[fix hooks] libarchive #3778

[fix hooks] libarchive #3778

Conversation

danimtb commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

conan-center-bot commented Dec 3, 2020

danimtb commented Dec 15, 2020

danimtb commented Dec 15, 2020

uilianries commented Dec 15, 2020

conan-center-bot commented Dec 15, 2020

uilianries commented Dec 15, 2020

uilianries commented Dec 15, 2020

danimtb commented Dec 15, 2020

uilianries commented Dec 15, 2020

conan-center-bot commented Dec 16, 2020

uilianries commented Dec 17, 2020

mathbunnyru commented Jan 7, 2021

conan-center-bot commented Jan 8, 2021

conan-center-bot commented Jan 11, 2021

conan-center-bot commented Jan 12, 2021

SpaceIm commented Jan 12, 2021 • edited Loading

mathbunnyru commented Jan 12, 2021

danimtb commented Jan 12, 2021

SpaceIm left a comment

Choose a reason for hiding this comment

dmn-star commented Jan 12, 2021

SpaceIm commented Jan 12, 2021 •

edited

Loading