Crowcpp 0.2 Fork, support for FreeBSD #4085

madduci · 2021-01-05T08:33:24Z

Specify library name and version: crowcpp-crow/0.2

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

… into master

conan-center-bot · 2021-01-05T08:34:12Z

Failure in build 1 (cea8765d4d46c4a134b4e3a9e9981db6973c8221):

crowcpp-crow/0.2
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-4085/recipes/crowcpp-crow/all/patches/001-disable-examples.patch' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041)

madduci · 2021-01-05T08:34:32Z

see #3064

conan-center-bot · 2021-01-05T08:36:07Z

Failure in build 2 (66d7a7479966af07ca08ed21ccb4523647a1a9e4):

crowcpp-crow/0.2
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-4085/recipes/crowcpp-crow/all/patches/001-disable-examples.patch' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041)

conan-center-bot · 2021-01-05T08:50:42Z

Some configurations of 'crowcpp-crow/0.2' failed in build 3 (0e3b07529151f7a0facd3545ab3e75fdfdb9ce77):

Linux x86_64, Release, gcc 4.9, libstdc++
Access to all the logs

conan-center-bot · 2021-01-05T09:30:20Z

All green in build 4 (c62d8027588d7d270d274c1741ba3d821b07d311)! 😊

crowcpp-crow/0.2: Generated 1 packages. All logs here

Croydon · 2021-01-05T09:56:36Z

recipes/crowcpp-crow/all/patches/001-disable-examples.patch

+ include_directories("${PROJECT_SOURCE_DIR}")
+
+-add_subdirectory(examples)
+#add_subdirectory(examples)


If I read it correctly, then you are part of this project right?

Could you please consider adding a CMake option like BUILD_EXAMPLES so that we don't need to patch it?

I'm not part of the project. The patch addresses an issue in the library that has been solved after the release tag v0.2. Until there's no new release of the library, I'm skipping the build of the examples, leaving only the tests active.
EDIT: This is the fix and it's in the master branch, not yet released: CrowCpp/Crow#63

The fix you're talking about is to be able to build examples in all environments.
But conan cci recipes prefer not to build examples at all.

To make it easy for the recipe, it would be great having this add_subdirectory(examples) under if (BUILD_EXAMPLES) and we would just BUILD_EXAMPLES to False, instead of patching.

What I suggest:

to make a PR in the crow project to add this variable (it may be ON by default, to not change the current behaviour)

then ask the developer to release 0.2.1.

After that patch for examples will not be required at all.

It might be an overkill and/or too difficult, but it would make maintenance easier for the future versions.

Yeah I understand your point, which I totally share. I will try to do my best

I've submitted the PR in the repository, the project maintainers plan to do a release soon. I will update the recipe once they'll release a new version!

mathbunnyru · 2021-01-05T11:15:59Z

recipes/crowcpp-crow/all/patches/001-disable-examples.patch

+ include_directories("${PROJECT_SOURCE_DIR}")
+
+-add_subdirectory(examples)
+#add_subdirectory(examples)


The fix you're talking about is to be able to build examples in all environments.
But conan cci recipes prefer not to build examples at all.

To make it easy for the recipe, it would be great having this add_subdirectory(examples) under if (BUILD_EXAMPLES) and we would just BUILD_EXAMPLES to False, instead of patching.

What I suggest:

to make a PR in the crow project to add this variable (it may be ON by default, to not change the current behaviour)

then ask the developer to release 0.2.1.

After that patch for examples will not be required at all.

It might be an overkill and/or too difficult, but it would make maintenance easier for the future versions.

prince-chrismc · 2021-01-05T17:06:07Z

recipes/crowcpp-crow/all/patches/001-disable-examples.patch

+-	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++14 -pedantic -Wextra")
+	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11 -pedantic -Wextra")


Why do you need to change the C++ version?

I've seen that no C++14 constructs are used, but C++11 is required by some boost header used in the project. Since the conan build system is using gcc 4.9, I've pushed it to C++11 instead of 14

We try to minimize the patches we apply, but this one follows the draft rules #3903 so okay!

prince-chrismc

According to the project https://github.com/CrowCpp/crow#attributions

There's a few missing external deps... I dont know where they come from though (not in the CMake)

The-EDev · 2021-01-05T17:45:39Z

@prince-chrismc

According to the project https://github.com/CrowCpp/crow#attributions

There's a few missing external deps... I dont know where they come from though (not in the CMake)

The attributions are for libraries that are copied into the code, all the mentioned libraries' header files are inside include/crow already. Hence why Boost and OpenSSL are not on the list, since they require the user to install them.

prince-chrismc · 2021-01-05T18:54:31Z

Ahhh thank you for the clarification!

I would discourage that since the consumer does not have any choice about which version is used... like the nodejs/http_parser is very common... I see it's wrapped with a crow namespace so it's on the safe side... but usually this produces conflicts

the only blocker is my question #4085 (comment)

I saw in my second pass it's a windows limitation for C++14 but that was a unix section...

recipes/crowcpp-crow/all/conanfile.py

uilianries · 2021-01-06T14:53:28Z

recipes/crowcpp-crow/all/patches/001-disable-examples.patch

+@@ -42,7 +42,7 @@ set(PROJECT_INCLUDE_DIR
+ include_directories("${PROJECT_INCLUDE_DIR}")
+ include_directories("${PROJECT_SOURCE_DIR}")
+
+-add_subdirectory(examples)
+#add_subdirectory(examples)
+
+ if (MSVC)
+ else()


Suggested change

@@ -42,7 +42,7 @@ set(PROJECT_INCLUDE_DIR

include_directories("${PROJECT_INCLUDE_DIR}")

include_directories("${PROJECT_SOURCE_DIR}")

-add_subdirectory(examples)

+#add_subdirectory(examples)

if (MSVC)

else()

Not required if you only build amalgamation as target.

recipes/crowcpp-crow/all/conanfile.py

Co-authored-by: Uilian Ries <[email protected]>

conan-center-bot · 2021-01-08T09:08:52Z

All green in build 5 (3a399287e977d97005d33293ae91ffaec964b3b4)! 😊

crowcpp-crow/0.2: Generated 1 packages. All logs here

prince-chrismc · 2021-01-08T14:24:17Z

Now that you are building only the main target you should be able to remove the patches and openssl requirement

you might need to explicitly copy ant not use the cmake.install in that case

conan-center-bot · 2021-01-08T15:16:19Z

All green in build 7 (29433a3cc31040fe9217d1c6556d943b1d0df971)! 😊

crowcpp-crow/0.2: Generated 1 packages. All logs here

prince-chrismc

LGTM!

recipes/crowcpp-crow/all/conanfile.py

Extending OS recognition to FreeBSD Co-authored-by: Anonymous Maarten <[email protected]>

mathbunnyru · 2021-01-11T05:14:30Z

@ericLemanissier could you run freebsd build, please?

conan-center-bot · 2021-01-11T05:17:24Z

All green in build 8 (0a8b5bdf40765f475378016d877057827d45031d)! 😊

crowcpp-crow/0.2: Generated 1 packages. All logs here

madebr · 2021-01-11T05:35:36Z

@mathbunnyru

@ericLemanissier could you run freebsd build, please?

You need to add FreeBSD to the title, for his script to pick up this pr.

conan-center-bot · 2021-01-11T06:03:35Z

All green in build 9 (0a8b5bdf40765f475378016d877057827d45031d)! 😊

crowcpp-crow/0.2: Generated 1 packages. All logs here

ericLemanissier · 2021-01-11T06:35:48Z

https://github.com/ericLemanissier/conan-center-index/runs/1679500069?check_suite_focus=true failed:

warning: No toolsets are configured.
warning: Configuring default toolset "gcc".
warning: If the default is wrong, your build may not work correctly.
warning: Use the "toolset=xxxxx" option to override our guess.
warning: For more configuration options, please consult
warning: http://boost.org/boost-build2/doc/html/bbv2/advanced/configuration.html
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/tools/gcc.jam:226: in gcc.init from module gcc
error: toolset gcc initialization:
error: no command provided, default command 'g++' not found
error: initialized from
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/build/toolset.jam:44: in toolset.using from module toolset
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/build-system.jam:658: in load from module build-system
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/kernel/modules.jam:295: in import from module modules
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/kernel/bootstrap.jam:139: in boost-build from module
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/boost-build.jam:8: in module scope from module

it tries to invoke g++, even if the profile should use clang

mathbunnyru · 2021-01-11T07:36:08Z

https://github.com/ericLemanissier/conan-center-index/runs/1679500069?check_suite_focus=true failed:

warning: No toolsets are configured.
warning: Configuring default toolset "gcc".
warning: If the default is wrong, your build may not work correctly.
warning: Use the "toolset=xxxxx" option to override our guess.
warning: For more configuration options, please consult
warning: http://boost.org/boost-build2/doc/html/bbv2/advanced/configuration.html
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/tools/gcc.jam:226: in gcc.init from module gcc
error: toolset gcc initialization:
error: no command provided, default command 'g++' not found
error: initialized from
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/build/toolset.jam:44: in toolset.using from module toolset
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/build-system.jam:658: in load from module build-system
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/kernel/modules.jam:295: in import from module modules
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/src/kernel/bootstrap.jam:139: in boost-build from module
/root/.conan/data/b2/4.2.0/_/_/build/723bca155d56e10e54e03a13336d979ffec56a56/source/boost-build.jam:8: in module scope from module

it tries to invoke g++, even if the profile should use clang

As far as I can tell, the problem is with boost, so I think this recipe is good to go.

SSE4 · 2021-01-11T07:39:13Z

@mathbunnyru I remember FreeBSD switched to clang some time ago, that might be required to use clang toolset instead of gcc in boost recipe. also, what about the conan profile for FreeBSD, does it use clang or gcc?

madebr · 2021-01-11T07:42:46Z

The problem is with boost.build (b2), not boost itself.

madduci · 2021-01-11T07:50:28Z

If my PR in the main project is approved, Boost and OpenSSL will be fully optional (only required by tests and examples), but the recipe for the "amalgamation" target will not require Boost and OpenSSL anymore. They will be required directly in the user's "conanfile.txt" or "conanfile.py" recipe in the project where crow is needed.

madduci and others added 7 commits October 2, 2020 06:17

Updated gSOAP to 2.8.106

b0057a8

Merge branch 'master' of https://github.com/conan-io/conan-center-index…

ac71496

… into master

Updated gSOAP dependency to use latest OpenSSL 1.1.1h

96fa724

Merge branch 'master' of https://github.com/conan-io/conan-center-index…

18fe658

… into master

Updated openssl dependency for sqlcipher

32029c1

Merge branch 'master' of https://github.com/conan-io/conan-center-index

160a9d5

Added crowcpp fork 0.2

cea8765

madduci mentioned this pull request Jan 5, 2021

[request] crow/0.1 #3064

Closed

conan-center-bot added the Failed label Jan 5, 2021

Fixed endline issue in patch file

66d7a74

Fixed endline issue in patch file

0e3b075

Added openssl, enabling C++11 flag

c62d802

conan-center-bot removed the Failed label Jan 5, 2021

Croydon reviewed Jan 5, 2021

View reviewed changes

mathbunnyru suggested changes Jan 5, 2021

View reviewed changes

prince-chrismc reviewed Jan 5, 2021

View reviewed changes

madduci mentioned this pull request Jan 6, 2021

Improving CMakeLists.txt CrowCpp/Crow#96

Merged

uilianries reviewed Jan 6, 2021

View reviewed changes

recipes/crowcpp-crow/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Jan 6, 2021

View reviewed changes

madebr reviewed Jan 8, 2021

View reviewed changes

recipes/crowcpp-crow/all/conanfile.py Show resolved Hide resolved

Update recipes/crowcpp-crow/all/conanfile.py

3a39928

Co-authored-by: Uilian Ries <[email protected]>

madduci added 2 commits January 8, 2021 15:04

Removing deprecated patch

6f4fbe5

Updating crow conan recipe

29433a3

prince-chrismc previously approved these changes Jan 8, 2021

View reviewed changes

madebr reviewed Jan 8, 2021

View reviewed changes

recipes/crowcpp-crow/all/conanfile.py Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Jan 8, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

mathbunnyru previously approved these changes Jan 10, 2021

View reviewed changes

Update recipes/crowcpp-crow/all/conanfile.py

0a8b5bd

Extending OS recognition to FreeBSD Co-authored-by: Anonymous Maarten <[email protected]>

madduci dismissed stale reviews from mathbunnyru and prince-chrismc via 0a8b5bd January 11, 2021 05:10

mathbunnyru approved these changes Jan 11, 2021

View reviewed changes

madduci changed the title ~~Crowcpp 0.2 Fork~~ Crowcpp 0.2 Fork, support for FreeBSD Jan 11, 2021

madebr approved these changes Jan 11, 2021

View reviewed changes

SSE4 approved these changes Jan 11, 2021

View reviewed changes

prince-chrismc approved these changes Jan 11, 2021

View reviewed changes

conan-center-bot merged commit 39698b6 into conan-io:master Jan 11, 2021

madduci deleted the crowcpp-crow branch January 12, 2021 08:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crowcpp 0.2 Fork, support for FreeBSD #4085

Crowcpp 0.2 Fork, support for FreeBSD #4085

madduci commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

madduci commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

Croydon Jan 5, 2021

madduci Jan 5, 2021 •

edited

Loading

mathbunnyru Jan 5, 2021

madduci Jan 6, 2021

madduci Jan 6, 2021

mathbunnyru Jan 5, 2021

prince-chrismc Jan 5, 2021

madduci Jan 6, 2021

prince-chrismc Jan 6, 2021

prince-chrismc left a comment

The-EDev commented Jan 5, 2021

prince-chrismc commented Jan 5, 2021 •

edited

Loading

uilianries Jan 6, 2021

conan-center-bot commented Jan 8, 2021

prince-chrismc commented Jan 8, 2021

conan-center-bot commented Jan 8, 2021

prince-chrismc left a comment

mathbunnyru commented Jan 11, 2021

conan-center-bot commented Jan 11, 2021

madebr commented Jan 11, 2021 •

edited

Loading

conan-center-bot commented Jan 11, 2021

ericLemanissier commented Jan 11, 2021 •

edited

Loading

mathbunnyru commented Jan 11, 2021

SSE4 commented Jan 11, 2021

madebr commented Jan 11, 2021

madduci commented Jan 11, 2021 •

edited

Loading

		- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++14 -pedantic -Wextra")
		+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11 -pedantic -Wextra")

Crowcpp 0.2 Fork, support for FreeBSD #4085

Crowcpp 0.2 Fork, support for FreeBSD #4085

Conversation

madduci commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

madduci commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

conan-center-bot commented Jan 5, 2021

Choose a reason for hiding this comment

madduci Jan 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prince-chrismc left a comment

Choose a reason for hiding this comment

The-EDev commented Jan 5, 2021

prince-chrismc commented Jan 5, 2021 • edited Loading

Choose a reason for hiding this comment

conan-center-bot commented Jan 8, 2021

prince-chrismc commented Jan 8, 2021

conan-center-bot commented Jan 8, 2021

prince-chrismc left a comment

Choose a reason for hiding this comment

mathbunnyru commented Jan 11, 2021

conan-center-bot commented Jan 11, 2021

madebr commented Jan 11, 2021 • edited Loading

conan-center-bot commented Jan 11, 2021

ericLemanissier commented Jan 11, 2021 • edited Loading

mathbunnyru commented Jan 11, 2021

SSE4 commented Jan 11, 2021

madebr commented Jan 11, 2021

madduci commented Jan 11, 2021 • edited Loading

madduci Jan 5, 2021 •

edited

Loading

prince-chrismc commented Jan 5, 2021 •

edited

Loading

madebr commented Jan 11, 2021 •

edited

Loading

ericLemanissier commented Jan 11, 2021 •

edited

Loading

madduci commented Jan 11, 2021 •

edited

Loading