Improving CMakeLists.txt

[madduci]

Hello

as suggested by Conan team, I've made some changes to the CMakeLists to make it better supported by conan recipes (but also by other package managers as well), using only what's needed and enabling/disabling tests and examples.

Here's a short list of what I'm trying to change upstream:

• Added options BUILD_EXAMPLES and BUILD_TESTING to switch examples on/off during compilation: examples are not built by default, Tests are
• Using standard CMake variable CMAKE_CXX_STANDARD to set the C++ Standard, independently from the compiler
• Using OpenSSL only if BUILD_EXAMPLES are activated, since it's required by Boost ASIO only at runtime as dynamic library

The Conan recipe is going under review here: conan-io/conan-center-index#4085

If this change is merged in the master branch, I'd kindly ask you to make a new Release tag, so it can be used in the Conan recipe as well.

[The-EDev]

Hi, Thanks a lot for the help.

Regarding the C++ version, while crow does support C++11 at the moment (by altering some functionality), the plan was to use C++14 features if needed, reading conan-io/conan-center-index#4085 (comment) I understand the reason. @mrozigor would this change cause problems?

As for the release tag, the plan is to finish #84 and #93 and release v0.3, by Monday at the absolute latest. Is that okay? or should we create an intermediate release and then another once the PRs are merged?

[vexy]

Looks good 👍

[madduci]

Hi @The-EDev
I'll wait then for the release 0.3 once you're done, please send me a ping when it's there, so I can update the conan recipe and point to the version.

[prince-chrismc]

There's also some outdate CMake

https://github.com/CrowCpp/crow/pull/96/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR27-R30

https://stackoverflow.com/a/24470998/8480874

I would suggestion just removing those lines in question

[madduci]

Sure, but I didn't want to do massive changes all at once.

[mrozigor]

Regarding the C++ version, while crow does support C++11 at the moment (by altering some functionality), the plan was to use C++14 features if needed, reading conan-io/conan-center-index#4085 (comment) I understand the reason. @mrozigor would this change cause problems?

Probably not until we use something 14 dependent ;)

[mrozigor]

Sure, but I didn't want to do massive changes all at once.

I think it a simple change (removing that one line). If you improve CMakeLists.txt, then go for it ;)

[madduci]

Ok then I would do a couple of improvements

[madduci]

@mrozigor @The-EDev I've upgraded the CMake, now Examples and Tests are enabled by default again, but they can be turned off (cmake .. -DBUILD_EXAMPLES=OFF -DBUILD_TESTING=OFF), not requiring either Boost or OpenSSL, to generate only the amalgamate version of crow.

I've added the equivalent of -Wall for MSVC (/W4) and some optimization flags, for tests and examples.

The compiler flags and the dependencies are now grouped in two separated files, to have a better overview of what is required.

Tell me if the PR fits your project, feel free to give me the feedbacks on that and how can I improve it.

[madduci]

Hi @mrozigor thanks for the review. I've bumped Boost to version 1.64.0 since on some systems the latest versions could not be available, what do you think?

[mrozigor]

Hi @mrozigor thanks for the review. I've bumped Boost to version 1.64.0 since on some systems the latest versions could not be available, what do you think?

Ok, I think that's reasonable ;) Good work.

[The-EDev]

Hi @mrozigor thanks for the review. I've bumped Boost to version 1.64.0 since on some systems the latest versions could not be available, what do you think?

I know I'm very late to the party, but this could be a problem, we discussed it in #29, this version of crow (as far as i know) does not work with boost<1.70

[madduci]

@The-EDev could you please try to reproduce the #29? If the bug is confirmed, then the Boost version can be bumped to 1.70.0