Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmilib: add recipe for version 2.4.1 #20256
fmilib: add recipe for version 2.4.1 #20256
Changes from all commits
91c1f83
8e69985
fe5739c
eed1b95
6f8fd9c
bfc74d2
0ef2f16
1cf10e7
8b3f0f5
ed70246
c3255d7
a616a6d
94483e4
e3b9ce9
517dd95
d918a85
0a60219
2070551
b30ae79
36f1153
808db31
b7f639b
90bb8b3
e066842
ad6a4bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is normally not required for CMake projects. What is the purpose of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is need when option
with_fmu=True
. Then, during the build process some executables need runtime access to what can be found in the virtual run environment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing the third party by Conan makes sense, but why do you need to add these files now? Is it something broken in the upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The third party minizip source that
fmilib
uses are modified so thatminizip
andminiunz
are functions rather than executables. This makes it necessary to add both the source and header files, which have modified function signatures (main -> mini{zip,unz}
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if you are including those files, the
minizip
library is still required?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because
minizip.c
includeszip.h
, andminiunz.c
includesunzip.h
; those files are provided byminizip
.