fmilib: add recipe for version 2.4.1 #20256

joakimono · 2023-10-02T08:55:31Z

Specify library name and version: fmilib/2.4.1

fmilibrary is a software package that enables integration of Functional Mock-up Units (FMUs). This library is an implementation of the FMI open standard.

This package is a dependency of the software provided by Open Simulation Platform.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

recipes/fmilibrary/all/conanfile.py

github-actions · 2023-10-30T13:13:34Z

Hooks produced the following warnings for commit 1cf10e7

fmilibrary/2.4.1@#04070e62827fcbbbbbc509f1b9d3d51c

post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libfmilib_shared.dylib
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\fmilib_shared.dll' links to system library 'shlwapi' but it is not in cpp_info.system_libs.

uilianries

Thank you for your pull request. I see many patches that could be sent to the upstream as well. Using find_package is not only a recommendation by Cmake part but also much safer than mimicking where artifacts are installed.

recipes/fmilibrary/all/conanfile.py

Co-authored-by: Uilian Ries <[email protected]>

recipes/fmilib/all/patches/2.4.1-003-use-expat-from-conan.patch

recipes/fmilib/all/patches/2.4.1-002-add-minizip-tools-as-functions.patch

- Simplify patches - Download minizip sources instead of patch - Write replace in file for a few minizip versions, 1.2.13 and 1.3.1 - Use CMakeDeps cmake_target_property instead of patching dependency target names

AbrilRBS

Hi! Sorry for the delay. I have some concerns/suggestions and questions, would love to get some insight on some of the changes :)

AbrilRBS · 2024-06-22T22:58:50Z

recipes/fmilib/all/conanfile.py

+        copy(self, "fmiModel*.h", self.dependencies["fmi1"].cpp_info.components["modex"].includedirs[0],
+             path.join(self.build_folder, "fmis", "FMI1"))
+        copy(self, "fmiPlatformTypes.h", self.dependencies["fmi1"].cpp_info.components["cosim"].includedirs[0],
+             path.join(self.build_folder, "fmis", "FMI1"))
+        copy(self, "fmiFunctions.h", self.dependencies["fmi1"].cpp_info.components["cosim"].includedirs[0],
+             path.join(self.build_folder, "fmis", "FMI1"))
+        copy(self, "*.h", self.dependencies["fmi2"].cpp_info.includedirs[0],
+             path.join(self.build_folder, "fmis", "FMI2"))


Any insights into why these folders can not to out of source for the build?

There is no reason. I moved them to the source folder instead.

AbrilRBS · 2024-06-22T23:02:39Z

recipes/fmilib/all/conanfile.py

+        minizip_code = {
+            "1.3.1":
+            {
+                "url": "https://zlib.net/fossils/zlib-1.3.1.tar.gz",
+                "sha256": "9a93b2b7dfdac77ceba5a558a580e74667dd6fede4585b91eefb60f03b72df23"
+            },
+            "1.2.13":
+            {
+                "url": "https://zlib.net/fossils/zlib-1.2.13.tar.gz",
+                "sha256": "b3a24de97a8fdbc835b9833169501030b8977031bcb54b3b3ac13740f846ab30"
+            }
+        }
+        get(self,
+            **minizip_code[str(self.dependencies["minizip"].ref.version)],
+            pattern="*/minizip/*",
+            strip_root=True, destination=path.join(self.build_folder))


Afaik, the library needs the actual source code for minizip instead of relying in the compiled library (Would appreciate insight into this too!)

You actually get access to the dependency's conandata thru the self.dependencies accessor, so this could be simplified to something like

Suggested change

minizip_code = {

"1.3.1":

{

"url": "https://zlib.net/fossils/zlib-1.3.1.tar.gz",

"sha256": "9a93b2b7dfdac77ceba5a558a580e74667dd6fede4585b91eefb60f03b72df23"

},

"1.2.13":

{

"url": "https://zlib.net/fossils/zlib-1.2.13.tar.gz",

"sha256": "b3a24de97a8fdbc835b9833169501030b8977031bcb54b3b3ac13740f846ab30"

}

}

get(self,

**minizip_code[str(self.dependencies["minizip"].ref.version)],

pattern="*/minizip/*",

strip_root=True, destination=path.join(self.build_folder))

minizip_version = self.dependencies["minizip"].ref.version

get(self,

**self.dependencies["minizip"].conandata["sources"][minizip_version],

pattern="*/minizip/*",

strip_root=True, destination=path.join(self.build_folder))

which allivieates some of your concerns - I would still like some way to avoid this, but alas seems like this will be that way to go forward

fmilib introduce minizip.c and minunz.c as functions instead of applications by changing their main functions. To do this, fmilib needs the minizip sources. It also uses other functionality in minizip, so the precompiled library is also needed. In patch file *002*.patch, you can see the new header files for the patched functions.

Your suggestion worked nicely, thank you!

- Fetch minizip source info from conan_data - Copy fmi headers into source folder rather than build folder

conan-center-bot · 2024-06-23T08:23:16Z

Conan v1 pipeline ✔️

All green in build 5 (ad6a4bb2f343e088f11072250ca2e14450f2cf9d):

fmilib/2.4.1:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (ad6a4bb2f343e088f11072250ca2e14450f2cf9d):

fmilib/2.4.1:
All packages built successfully! (All logs)

joakimono · 2024-07-03T10:52:08Z

Hi! Sorry for the delay. I have some concerns/suggestions and questions, would love to get some insight on some of the changes :)
@AbrilRBS: Hi, have I addressed your suggestions and questions, or do you have further inquiries?

AbrilRBS · 2024-07-03T13:21:47Z

Hi @joakimono sorry for the radio silence - I've been talking with @uilianries and we're checking some changes to the recipe to make it a bit more maintenable, sorry that I didn't communitcate it better!

joakimono · 2024-07-25T10:29:28Z

Hi @joakimono sorry for the radio silence - I've been talking with @uilianries and we're checking some changes to the recipe to make it a bit more maintenable, sorry that I didn't communitcate it better!

Hi @AbrilRBS, have you been able to check the changes for maintainability yet? I'm was hoping to get this recipe merged soon.

uilianries · 2024-07-26T06:59:14Z

@joakimono Sorry our delay, I spent some hours analyzing fmi and it's really complicated to get unvendorized as I see, that's why you needed to apply so many patches. Only AUR (Arch Linux) and vcpkg are packaging fmilib as well, and both are not trying to unvendor everything due complexity/fragility.

I'll bring this PR to be discussed with Conan team, but personally I'm more inclined to avoid all those patches related to unvendor. This is not the first recipe in CCI that we have this situation (see BehaviorTree). I would suggest discussing first with the upstream, to enable external dependencies instead via CMake options, it could be re-used by any user in the future.

Using Conan package instead of those vendorized is good as we can control the dependencies, but not always the author wants it, we had a project using vendorized dependencies and the author did not want to use external instead, to keep all aligned and tested with that specific versions, so users would have the same behavior always.

joakimono · 2024-07-26T10:57:31Z

Thank you for your reply. I agree that the option to unvendor dependencies is best handled by the upstream package. I posted an issue on this, modelon-community/fmi-library#100, last November, but I do not think it is prioritized. I will see if I can provide a pull request to fmi-library to achieve it, perhaps it would expedite matters.

uilianries · 2024-07-26T11:24:36Z

@joakimono Thank you for your feedback and pointing that issue. I'll try to take a look during this weekend as side-project too. 😄

uilianries · 2024-07-29T06:44:34Z

I sent the first PR to separate Expat this weekend: modelon-community/fmi-library#134

I think the best way is sending separated PRs, otherwise it would be hard not only to be tested, but also reviewed, as there are several dependencies. Once accepted/merged, I can send a next PR.

github-actions · 2024-10-14T06:41:16Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions · 2024-11-14T06:40:45Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

fmilibrary: add recipe for version 2.4.1

91c1f83

joakimono marked this pull request as draft October 2, 2023 08:55

Remove alpha version remnants

8e69985

conan-center-bot added Failed Unexpected Error labels Oct 3, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into fmilibrary/new-package

fe5739c

conan-center-bot removed the Unexpected Error label Oct 3, 2023

This comment has been minimized.

Sign in to view

kyllingstad mentioned this pull request Oct 9, 2023

Conan v2 open-simulation-platform/conan-fmilibrary#14

Merged

kyllingstad mentioned this pull request Oct 18, 2023

Conan v2 combability open-simulation-platform/libcosim#718

Closed

kyllingstad reviewed Oct 23, 2023

View reviewed changes

recipes/fmilibrary/all/conanfile.py Outdated Show resolved Hide resolved

joakimono added 2 commits October 25, 2023 14:00

Add missing include and reviewer suggestion

eed1b95

Merge branch 'master' into fmilibrary/new-package

6f8fd9c

This comment has been minimized.

Sign in to view

joakimono added 2 commits October 30, 2023 09:34

fmilibrary does not support armv8 Macos yet

bfc74d2

Make zlib a direct dependency

0ef2f16

This comment has been minimized.

Sign in to view

Fix shared build windows

1cf10e7

conan-center-bot removed the Failed label Oct 30, 2023

This comment has been minimized.

Sign in to view

joakimono marked this pull request as ready for review October 30, 2023 13:13

prince-chrismc mentioned this pull request Oct 30, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

Fix post package warnings

8b3f0f5

This comment has been minimized.

Sign in to view

uilianries reviewed Oct 30, 2023

View reviewed changes

uilianries self-assigned this Oct 30, 2023

joakimono and others added 2 commits October 31, 2023 09:20

Apply suggestions from code review

ed70246

Co-authored-by: Uilian Ries <[email protected]>

Move fmi copy to build and bump expat to 2.5.0

c3255d7

valgur reviewed Mar 24, 2024

View reviewed changes

recipes/fmilib/all/patches/2.4.1-003-use-expat-from-conan.patch Outdated Show resolved Hide resolved

valgur reviewed Mar 24, 2024

View reviewed changes

recipes/fmilib/all/patches/2.4.1-002-add-minizip-tools-as-functions.patch Outdated Show resolved Hide resolved

conan-center-bot requested a review from AbrilRBS May 3, 2024 11:41

ErniGH mentioned this pull request Jun 14, 2024

Prioritization of new recipe PRs #24327

Open

Merge branch 'conan-io:master' into fmilibrary/new-package

b7f639b

This comment has been minimized.

Sign in to view

Address review comments

90bb8b3

- Simplify patches - Download minizip sources instead of patch - Write replace in file for a few minizip versions, 1.2.13 and 1.3.1 - Use CMakeDeps cmake_target_property instead of patching dependency target names

conan-center-bot added the Service Under Maintenance label Jun 19, 2024

This comment has been minimized.

Sign in to view

conan-center-bot removed the Service Under Maintenance label Jun 19, 2024

This comment has been minimized.

Sign in to view

Remove unused import

e066842

This comment has been minimized.

Sign in to view

joakimono requested a review from valgur June 21, 2024 14:10

AbrilRBS reviewed Jun 22, 2024

View reviewed changes

Address review comments

ad6a4bb

- Fetch minizip source info from conan_data - Copy fmi headers into source folder rather than build folder

conan-center-bot requested a review from AbrilRBS August 19, 2024 11:39

conan-center-bot requested a review from franramirez688 September 13, 2024 11:38

github-actions bot added the stale label Oct 14, 2024

github-actions bot closed this Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fmilib: add recipe for version 2.4.1 #20256

fmilib: add recipe for version 2.4.1 #20256

joakimono commented Oct 2, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 30, 2023

This comment has been minimized.

uilianries left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

AbrilRBS Jun 22, 2024

joakimono Jun 23, 2024

AbrilRBS Jun 22, 2024

joakimono Jun 23, 2024 •

edited

Loading

conan-center-bot commented Jun 23, 2024

joakimono commented Jul 3, 2024

AbrilRBS commented Jul 3, 2024

joakimono commented Jul 25, 2024

uilianries commented Jul 26, 2024

joakimono commented Jul 26, 2024

uilianries commented Jul 26, 2024

uilianries commented Jul 29, 2024

github-actions bot commented Oct 14, 2024

github-actions bot commented Nov 14, 2024

fmilib: add recipe for version 2.4.1 #20256

fmilib: add recipe for version 2.4.1 #20256

Conversation

joakimono commented Oct 2, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 30, 2023

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

AbrilRBS Jun 22, 2024

Choose a reason for hiding this comment

joakimono Jun 23, 2024

Choose a reason for hiding this comment

AbrilRBS Jun 22, 2024

Choose a reason for hiding this comment

joakimono Jun 23, 2024 • edited Loading

Choose a reason for hiding this comment

conan-center-bot commented Jun 23, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

joakimono commented Jul 3, 2024

AbrilRBS commented Jul 3, 2024

joakimono commented Jul 25, 2024

uilianries commented Jul 26, 2024

joakimono commented Jul 26, 2024

uilianries commented Jul 26, 2024

uilianries commented Jul 29, 2024

github-actions bot commented Oct 14, 2024

github-actions bot commented Nov 14, 2024

joakimono commented Oct 2, 2023 •

edited

Loading

joakimono Jun 23, 2024 •

edited

Loading