qpdf/11.1.1 add (lib only) package

[cguentherTUChemnitz]

Specify library name and version: qpdf/11.1.0

I am not a maintainer of the qpdf project, but i would like to have it in the conan package ecosystem. The project speaks best on its-self:
https://github.com/qpdf/qpdf

The project provides cli tools as well as c++ and c libraries.

One explanation for the decision to go for libjpeg-turbo as hardcoded requirement:
libjpeg produces runtime errors in the package-test with:

error while getting stream data for 7 0 R: Wrong JPEG library version: library is 90, caller expects 80

This seems that i would have to downgrade libjpeg to something that is not present on the conan repository. Nevertheless i was happy to find out that libjpeg-turbo was just working fine.

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[cguentherTUChemnitz]

Mh it seems there is an requirement from within qpdf to require a more modern cmake version that installed on the ci-runners, since they report:

-- Configuring incomplete, errors occurred!
qpdf/11.1.0: 
CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
  CMake 3.16 or higher is required.  You are running version 3.15.7

What is the way here to go? I an upgrade on ci-systems necessary? That would wonder me since other packages are using cmake version 3.16 in there test_package, like in boost-ext-ut/all/test_package/CMakeLists.txt. So how such a package was able to merge? Would it be a solution to add cmake from conan in a more modern version as a build_requirement?

[uilianries]

@cguentherTUChemnitz You should add cmake as tool_requires, in build_requirements() method: https://docs.conan.io/en/latest/migrating_to_2.0/recipes.html#requirements

[uilianries]

Thank you for your contribution. Please, refine the template according to your target project, remove unused methods and comments.

[cguentherTUChemnitz]

Thank you for your contribution. Please, refine the template according to your target project, remove unused methods and comments.

Thanks for your pleasant examples and documentations as well as your fast and detailed feedback ;) I will do it shortly

[github-actions]

Hooks produced the following warnings for commit e9d6be8

qpdf/11.1.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libqpdf.so' links to system library 'm' but it is not in cpp_info.system_libs.

[cguentherTUChemnitz]

@uilianries I tried to update everything as your review suggest.

• removed a lot of comments from the templates
• shrinked down the test to some version printing instead of doing real work
• introduced with_crypto option to select between native and openssl (didn't find the third way of gnutls on conan)
• revisited the linked system libs (only libm seems to be necessary here, as mentioned from the great conan ci-builds)

Do you think this is now in a mergeable state?

[cguentherTUChemnitz]

@uilianries fine that way?

continuous-integration/jenkins/pr-merge Expected — Waiting for status to be reported
Do i have to do something here, or is it just wait for the scheduled build job?

[cguentherTUChemnitz]

@uilianries Are we finished here? Can we trigger additional people to provide the necessary reviews?

[uilianries]

LGTM

[cguentherTUChemnitz]

Sry guys for all the patch-rounds here, but i do not have a windows platform at hand, so i have to do quite some ping-pong with the ci.

[cguentherTUChemnitz]

@uilianries What is here to do, when crucial dependency like the default used openssl is missing here on ci as prebuilt package?

[cguentherTUChemnitz]

@uilianries @prince-chrismc I think we are finally here in a mergeable state with openssl conan support for all major platforms ;)

[prince-chrismc]

Isn't the dependencies the other way around? 😖

[cguentherTUChemnitz]

A yes, your are right. I think it it not necessary to add the comment here after all, since updating dependencies is like an on-going todo... I would just now remove the comment to solve the discussion here.

[prince-chrismc]

This can go in the parch I think

[cguentherTUChemnitz]

Mh, it is possible, but i would like to have the handling for the FOUND_CRYPTO, USE_CRYPTO_OPENSSL, USE_CRYPTO_GNUTLS, USE_CRYPTO_NATIVE next to each other, since they are already contextwise near to each other. Since the use_crypto_xxx flags are easier handled in the conanfile.py, since they are dependending on the conan options, i would like to keep the FROUND_CRYPTO also there. Is that fine for you, @prince-chrismc ?

[conan-center-bot]

All green in build 59 (3aed2bbce8c3a332847aeae3b7b3d356a51f7774):

• qpdf/11.1.1@:
  All packages built successfully! (All logs)

[uilianries]

LGTM. Separating that patch could be a good improvement, but it's good enough now.