Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] qpdf/11.1.0; reviewers required #13153

Closed
cguentherTUChemnitz opened this issue Sep 26, 2022 · 4 comments
Closed

[request] qpdf/11.1.0; reviewers required #13153

cguentherTUChemnitz opened this issue Sep 26, 2022 · 4 comments
Labels
question Further information is requested

Comments

@cguentherTUChemnitz
Copy link
Contributor

Package Details

Description Of The Library / Tool

qpdf provides command line binaries as well as c and c++ libraries. It is a 2.1k github stars project.

pull-request already there:
#13113

Locally it is working fine, even with a complete conan package test from qpdf examples generating a new pdf.
It is at the moment red in ci build states, just because of:

-- Configuring incomplete, errors occurred!
qpdf/11.1.0: 
CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
  CMake 3.16 or higher is required.  You are running version 3.15.7

How to cope here with the cmake version requirement mismatch between ci and the package? Especially interesting is that boost-ext-ut/all/test_package/CMakeLists.txt was already able to merge with such a high cmake requirement. How was that solved there?

@ericLemanissier
Copy link
Contributor

you can add self.tool_requires("cmake/3.24.1") to the build_requires method

@cguentherTUChemnitz
Copy link
Contributor Author

Thanks for pointing out the way to go. I updated accordingly the PR

@cguentherTUChemnitz cguentherTUChemnitz changed the title [request] qpdf/11.1.0; help necessary for too old cmake version on ci-runners [request] qpdf/11.1.0; reviewers required Sep 26, 2022
@uilianries uilianries added question Further information is requested and removed library request labels Sep 26, 2022
@ericLemanissier
Copy link
Contributor

@cguentherTUChemnitz this can be closed. #13113 is merged

@uilianries
Copy link
Member

Fixed by #13113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants