Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stop after onDictate regardless abortability #66

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Allow stop after onDictate regardless abortability #66

merged 1 commit into from
Jun 1, 2021

Conversation

compulim
Copy link
Owner

@compulim compulim commented Jun 1, 2021

Changelog

Please copy and paste new entries from CHANGELOG.md here.

Fixed

  • Fixed #65. Setting started to false after onDictate callback should succeed even on an unabortable recognition, by @compulim, in PR #66

Specific changes

Please list each individual specific change in this pull request.

  • Immediately before onDictate callback, unattach the speechRecognition instance, so setting started to false (a.k.a. stopping) should not trigger "cannot abort an unabortable recognition" exception

@compulim compulim self-assigned this Jun 1, 2021
@compulim compulim merged commit 0d6fd36 into main Jun 1, 2021
@compulim compulim deleted the fix-65-stop-for-unabortable branch June 1, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compulim compulim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting started to false for unabortable recognition should not fail after onDictate complete
1 participant
@compulim