Allow stop with unabortables after onDictate (#66)

compulim · Jun 1, 2021 · 0d6fd36 · 0d6fd36
1 parent 75400ad
commit 0d6fd36
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed [#65](https://github.com/compulim/react-dictate-button/issues/65). Setting `started` to `false` after `onDictate` callback should succeed even on an unabortable recognition, by [@compulim](https://github.com/compulim), in PR [#66](https://github.com/compulim/react-dictate-button/pull/66)
+
 ## [2.0.0] - 2021-05-16
 
 ### Breaking changes

diff --git a/packages/component/src/Composer.js b/packages/component/src/Composer.js
@@ -80,10 +80,12 @@ const Composer = ({
       }
 
       recognitionRef.current = undefined;
-
       setReadyState(0);
 
-      emitDictateOnEndRef.current && onDictateRef.current && onDictateRef.current({ type: 'dictate' });
+      if (emitDictateOnEndRef.current) {
+        onDictateRef.current && onDictateRef.current({ type: 'dictate' });
+        emitDictateOnEndRef.current = false;
+      }
     },
     [emitDictateOnEndRef, onDictateRef, recognitionRef, setReadyState]
   );
@@ -143,15 +145,19 @@ const Composer = ({
         const first = rawResults[0];
 
         if (first.isFinal) {
-          emitDictateOnEndRef.current = false;
+          // After "onDictate" callback, the caller should be able to set "started" to false on an unabortable recognition.
+          // TODO: Add test for fortification.
+          recognitionRef.current = undefined;
+          setReadyState(0);
+
           onDictateRef.current && onDictateRef.current({ result: results[0], type: 'dictate' });
         } else {
           onProgressRef.current &&
             onProgressRef.current({ abortable: recognitionAbortable(target), results, type: 'progress' });
         }
       }
     },
-    [emitDictateOnEndRef, onDictateRef, onProgressRef, recognitionRef]
+    [onDictateRef, onProgressRef, recognitionRef, setReadyState]
   );
 
   const handleStart = useCallback(