Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reset): Add cycle detection fix for services that are prefixed with the name of a preceding service #704

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Oct 29, 2024

Fixed the cycle detector #703

It detects cycle for services that are prefixed with the name of a preceding service
docker/compose#12235 (comment)

…th the name of a preceding service

Signed-off-by: Suleiman Dibirov <[email protected]>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @idsulik for the quick fix and for adding the test 🙏

@glours glours merged commit c2ef638 into compose-spec:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants