Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reset): Add cycle detector in reset.go #703

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Oct 26, 2024

Issue: docker/compose#12235
I added the cycle detector to reset.go.
Example yaml to reproduce the issue:

x-healthcheck: &healthcheck
  healthcheck:
    test: [ "CMD", "wget", "--quiet", "--spider", "--timeout=1", "http://localhost:9000/health/live" ]
    start_period: 20s
    start_interval: 1s
    interval: 30s
    timeout: 2s
    retries: 5


  egress-service:
    <<: *healthcheck

@idsulik idsulik requested a review from ndeloof as a code owner October 26, 2024 07:09
Signed-off-by: Suleiman Dibirov <[email protected]>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @idsulik for the fix

@glours glours merged commit 222d93c into compose-spec:main Oct 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants