Fix typo in types.Resource Pid field #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you need to sign off your commit to conform to contributor rules on this repo |
Signed-off-by: Austin Raney <[email protected]>
|
@ndeloof, sorry about that. It's been signed now. |
milas
approved these changes
May 26, 2023
ndeloof
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty small and isolated, but unfortunately still a breaking change :(. For better or worse, this change doesn't appear to break any
compose-gosource or tests. If there are any existing or new tests that you'd like me to add to include in this, please let me know and i'm happy to add them!fixes #400.