Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential typo in types.Resource Pids field name #400

Closed
aaraney opened this issue May 11, 2023 · 1 comment · Fixed by #404
Closed

Potential typo in types.Resource Pids field name #400

aaraney opened this issue May 11, 2023 · 1 comment · Fixed by #404

Comments

@aaraney
Copy link
Contributor

aaraney commented May 11, 2023

compose-go/types/types.go

Line 643 in 4e62a57

PIds int64 `yaml:"pids,omitempty" json:"pids,omitempty"`

Was this intended to be spelled this way? Or should it be spelled Pids? The analog, ResourceLimit, of this struct in github.com/docker/cli/cli/compose/types used Pids.

LMK if this is the case and im happy to submit a PR!
@ndeloof
Copy link
Collaborator

ndeloof commented May 15, 2023

That's indeed a typo.
A PR is welcome so you will be listed as a new contributor :)

aaraney pushed a commit to aaraney/compose-go that referenced this issue May 16, 2023
@aaraney
fix spelling of types.Resource Pid field. fixes compose-spec#400
3eca4f4
aaraney added a commit to aaraney/compose-go that referenced this issue May 16, 2023
@aaraney
fix spelling of types.Resource Pid field. fixes compose-spec#400
a7100f3
@aaraney aaraney mentioned this issue May 16, 2023
Merged
aaraney added a commit to aaraney/compose-go that referenced this issue May 16, 2023
@aaraney
fix spelling of types.Resource Pid field. fixes compose-spec#400
3d7014e 
Signed-off-by: Austin Raney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in types.Resource Pid field aaraney/compose-go
2 participants
@ndeloof @aaraney