-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open React-Select does not follow "window" scroll #433
Comments
I did a little bit of investigation with this:
One further area of investigation might be to piggyback the portal providing class used by modals, this would mean that we could insert the menus relative to the scrolling div. |
https://codesandbox.io/s/43n7z1v374?from-embed This shows a potential approach. |
I am removing this from the beta release for now, as there don't seem to be any easy fixes. |
Could perhaps use |
React-select already does something similar to Something similar which seems like it would solve the issue would be to use the |
The react select issue has moved to: JedWatson/react-select#4088 |
One additional consideration here is window height. Native select elements are able to overlap window boundaries: This isn't ever going to be possible with the current approach as far as I can tell, which means we will always have issues where the list is longer than the remaining offset from the bottom of the select element. Perhaps we are making a headache for ourselves? Two solutions:
My view is we should implement the first one in the short term, to resolve this issue. We can then earnestly think about the second one, and revisit the intention of rich select items for choosing an input component. The original design was some sort of full screen "chooser" with a summary component. Alternatively, we could go straight to number 2. Happy to hear what others think! |
Can be seen when editing an EditableList item, such as a prompt.
Could be:
If issue with our implementation we should update to fix.
The text was updated successfully, but these errors were encountered: