Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit forms inline #431

Merged
merged 26 commits into from
Mar 27, 2019
Merged

Edit forms inline #431

merged 26 commits into from
Mar 27, 2019

Conversation

wwqrd
Copy link
Contributor

@wwqrd wwqrd commented Mar 25, 2019

  • Form configuration is now part of particular interface where it is used
  • Form fields are added inline, which automatically creates corresponding
    variable entries

Resolves #390

@wwqrd wwqrd requested a review from jthrilly March 25, 2019 15:32
@wwqrd
Copy link
Contributor Author

wwqrd commented Mar 25, 2019

Demo/review feedback

  • From the node type editor don't require minimum number of variables.
  • "Prompt" should be a Text input
  • Add /check guidance / descriptive text for new fields
  • For form section, clearly link the title and fields: mini divider? box outline?
  • Radio groups etc, should be able to add options
  • Variable name isn't showing up in field editor for previously saved field.
  • Field preview should be improved: variable name (e.g. "Name"), variable type (as color). Perhaps as a "tag" style.
  • scrolling with select react component not following, create new issue?
  • TextArea max width (see field prompt), min-height, create new issue?

@wwqrd
Copy link
Contributor Author

wwqrd commented Mar 26, 2019

Text area issue: complexdatacollective/Network-Canvas-UI#101

@wwqrd
Copy link
Contributor Author

wwqrd commented Mar 26, 2019

@wwqrd wwqrd force-pushed the feature/inline-forms branch from 65d1c08 to 02034ef Compare March 26, 2019 18:09
@wwqrd wwqrd force-pushed the feature/inline-forms branch from 02034ef to 2d3eeb6 Compare March 26, 2019 18:17
@wwqrd wwqrd requested a review from rebeccamadsen March 26, 2019 18:17
@wwqrd wwqrd self-assigned this Mar 26, 2019
@wwqrd
Copy link
Contributor Author

wwqrd commented Mar 26, 2019

This looks done to me? @rebeccamadsen @jthrilly

I think the Options input (for radio group etc) could do with validations, but since that's a pre-existing component, I suggest we make that a separate PR.

@wwqrd wwqrd merged commit 814ff9c into master Mar 27, 2019
@wwqrd wwqrd deleted the feature/inline-forms branch March 27, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant