-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit forms inline #431
Merged
Merged
Edit forms inline #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo/review feedback
|
Text area issue: complexdatacollective/Network-Canvas-UI#101 |
React select issue: https://github.com/codaco/Architect/issues/433 |
wwqrd
force-pushed
the
feature/inline-forms
branch
from
March 26, 2019 18:09
65d1c08
to
02034ef
Compare
wwqrd
force-pushed
the
feature/inline-forms
branch
from
March 26, 2019 18:17
02034ef
to
2d3eeb6
Compare
This looks done to me? @rebeccamadsen @jthrilly I think the Options input (for radio group etc) could do with validations, but since that's a pre-existing component, I suggest we make that a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variable entries
Resolves #390