-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
menuShouldBlockScroll also blocks menu scrolling. #3929
Comments
Hey @2Steaks would you be replicate the issue in a codesandbox? It'd be easier to comprehend the issue with an example. |
Good shout @flexdinesh, here you go: https://codesandbox.io/s/festive-dirac-izf5y?fontsize=14&hidenavigation=1&theme=dark |
Confirmed the same issue for me, @flexdinesh do you check this bug in sandbox? |
Hi @JedWatson can you give any more insights into this? This is a big bummer :( |
Hey @2Steaks thanks for the codesandbox I can see it now. I'll get to it sometime soon. I'll update here once we make progress. |
Hey team, any news around a fix for this? maybe a temporary one? is going back to 3.0.4 the only workaround for now? |
@flexdinesh reverting this commit seems to fix the issue. |
@flexdinesh Even we are waiting for this fix as we are using 3.1.0 features as well and do not want to go back to 3.04 version. Please let us know once you revert the 691a011#diff-16745c8f19a824159168a93abf7bb78b or give any other solution . Thank you ! |
Hello - Thanks for reporting this issue. This bug has been reported multiple times as per issue #4088. A new master issue #4088 has since been created to keep track this this bug. This new issue will exist as the source of truth going forward to investigate the issue, report findings, and implement a bug fix. We'll take into account all the details above while investigating. If you feel this issue has been wrongly closed as it isn't related to the new master issue #4088, please let us know and we'll take another look. Thank you! |
@Eddie-CooRo Is this still an issue for you? It would be great if you could create a CodeSandbox that reproduces the issue. |
Ugh... I was following this issue and #4088 for over one-two months already 😅 For book-keeping purposes, this issue is "solved" in v4 😍 ✌️ |
I am experiencing this issue at v4.3.0 :( The next config sometimes blocks menu scrolling:
UPD: I were using custom component for MenuList without components.MenuList - that was the reason. |
For me it was not passing and spreading the base props for custom menuList styling |
Hi, I'm using menuPortalTarget to render outside of containers with overflow hidden such as table rows. In order for the menu position to be correct I have to set menuPosition to fixed. This works great except when you scroll the page and the menu position is not recalculated. To fix this I then use menuShouldBlockScroll which in combination with the other props achieves the desired result except for the fact that menuShouldBlockScroll also blocks the menu (has max-height with scroll auto) contents from being scrollable.
Would it be possible to prevent scrolling for all elements except for
.react-select__menu-list
?The text was updated successfully, but these errors were encountered: