[#4358,#4359] Feature/LDAP Decommissioning

- Removed LDAP group endpoints (icla,ecla) - Updated gerrit onboarding API input with no icla &&& ccla group IDs - Updated signed handlers to remove ldap group additions on signing - Updated approval list handling of gerrit users (TODO - update a new way of handling users) Signed-off-by: Harold Wanyama <[email protected]>
communitybridge · Jun 17, 2024 · f8b063a · f8b063a
1 parent 0ab3ec8
commit f8b063a
Show file tree

Hide file tree

Showing 15 changed files with 707 additions and 835 deletions.
diff --git a/cla-backend-go/cmd/dynamo_events_lambda/main.go b/cla-backend-go/cmd/dynamo_events_lambda/main.go
@@ -115,12 +115,7 @@ func init() {
 	githubOrganizationsService := github_organizations.NewService(githubOrganizationsRepo, repositoriesRepo, projectClaGroupRepo)
 	repositoriesService := repositories.NewService(repositoriesRepo, githubOrganizationsRepo, projectClaGroupRepo)
 
-	gerritService := gerrits.NewService(gerritRepo, &gerrits.LFGroup{
-		LfBaseURL:    configFile.LFGroup.ClientURL,
-		ClientID:     configFile.LFGroup.ClientID,
-		ClientSecret: configFile.LFGroup.ClientSecret,
-		RefreshToken: configFile.LFGroup.RefreshToken,
-	})
+	gerritService := gerrits.NewService(gerritRepo)
 	// Services
 	projectService := service.NewService(projectRepo, repositoriesRepo, gerritRepo, projectClaGroupRepo, usersRepo)
 

diff --git a/cla-backend-go/cmd/gitlab_repository_check/handler/handler.go b/cla-backend-go/cmd/gitlab_repository_check/handler/handler.go
@@ -137,12 +137,7 @@ func Handler(ctx context.Context) error {
 		v1ProjectClaGroupRepo,
 	})
 
-	gerritService := gerrits.NewService(gerritRepo, &gerrits.LFGroup{
-		LfBaseURL:    configFile.LFGroup.ClientURL,
-		ClientID:     configFile.LFGroup.ClientID,
-		ClientSecret: configFile.LFGroup.ClientSecret,
-		RefreshToken: configFile.LFGroup.RefreshToken,
-	})
+	gerritService := gerrits.NewService(gerritRepo)
 
 	approvalsTableName := "cla-" + stage + "-approvals"
 

diff --git a/cla-backend-go/cmd/migrate_approval_list/main.go b/cla-backend-go/cmd/migrate_approval_list/main.go
@@ -81,7 +81,7 @@ func init() {
 		v1ProjectClaGroupRepo,
 	})
 	ghOrgRepo = github_organizations.NewRepository(awsSession, stage)
-	gerritService = gerrits.NewService(gerritsRepo, nil)
+	gerritService = gerrits.NewService(gerritsRepo)
 	signatureRepo = signatures.NewRepository(awsSession, stage, companyRepo, usersRepo, eventsService, &ghRepo, ghOrgRepo, gerritService, approvalRepo)
 
 	log.Info("initialized repositories\n")

diff --git a/cla-backend-go/cmd/server.go b/cla-backend-go/cmd/server.go
@@ -273,13 +273,7 @@ func server(localMode bool) http.Handler {
 		v1ProjectClaGroupRepo,
 	})
 
-	gerritService := gerrits.NewService(gerritRepo, &gerrits.LFGroup{
-		LfBaseURL:     configFile.LFGroup.ClientURL,
-		ClientID:      configFile.LFGroup.ClientID,
-		ClientSecret:  configFile.LFGroup.ClientSecret,
-		RefreshToken:  configFile.LFGroup.RefreshToken,
-		EventsService: eventsService,
-	})
+	gerritService := gerrits.NewService(gerritRepo)
 
 	// Signature repository handler
 	signaturesRepo := signatures.NewRepository(awsSession, stage, v1CompanyRepo, usersRepo, eventsService, gitV1Repository, githubOrganizationsRepo, gerritService, approvalsRepo)

diff --git a/cla-backend-go/gerrits/mocks/mock_repository.go b/cla-backend-go/gerrits/mocks/mock_repository.go
diff --git a/cla-backend-go/gerrits/models.go b/cla-backend-go/gerrits/models.go
@@ -27,18 +27,15 @@ type Gerrit struct {
 // toModel converts the gerrit structure into a response model
 func (g *Gerrit) toModel() *models.Gerrit {
 	return &models.Gerrit{
-		DateCreated:   g.DateCreated,
-		DateModified:  g.DateModified,
-		GerritID:      strfmt.UUID4(g.GerritID),
-		GerritName:    g.GerritName,
-		GerritURL:     strfmt.URI(g.GerritURL),
-		GroupIDCcla:   g.GroupIDCcla,
-		GroupIDIcla:   g.GroupIDIcla,
-		GroupNameCcla: g.GroupNameCcla,
-		GroupNameIcla: g.GroupNameIcla,
-		ProjectID:     g.ProjectID,
-		Version:       g.Version,
-		ProjectSFID:   g.ProjectSFID,
+		DateCreated:  g.DateCreated,
+		DateModified: g.DateModified,
+		GerritID:     strfmt.UUID4(g.GerritID),
+		GerritName:   g.GerritName,
+		GerritURL:    strfmt.URI(g.GerritURL),
+		GroupIDCcla:  g.GroupIDCcla,
+		ProjectID:    g.ProjectID,
+		Version:      g.Version,
+		ProjectSFID:  g.ProjectSFID,
 	}
 }
 

diff --git a/cla-backend-go/gerrits/repository.go b/cla-backend-go/gerrits/repository.go
@@ -71,18 +71,15 @@ func (repo *repo) AddGerrit(ctx context.Context, input *models.Gerrit) (*models.
 	}
 	_, currentTime := utils.CurrentTime()
 	gerrit := &Gerrit{
-		DateCreated:   currentTime,
-		DateModified:  currentTime,
-		GerritID:      gerritID.String(),
-		GerritName:    input.GerritName,
-		GerritURL:     input.GerritURL.String(),
-		GroupIDCcla:   input.GroupIDCcla,
-		GroupIDIcla:   input.GroupIDIcla,
-		GroupNameCcla: input.GroupNameCcla,
-		GroupNameIcla: input.GroupNameIcla,
-		ProjectID:     input.ProjectID,
-		ProjectSFID:   input.ProjectSFID,
-		Version:       input.Version,
+		DateCreated:  currentTime,
+		DateModified: currentTime,
+		GerritID:     gerritID.String(),
+		GerritName:   input.GerritName,
+		GerritURL:    input.GerritURL.String(),
+		GroupIDCcla:  input.GroupIDCcla,
+		ProjectID:    input.ProjectID,
+		ProjectSFID:  input.ProjectSFID,
+		Version:      input.Version,
 	}
 	av, err := dynamodbattribute.MarshalMap(gerrit)
 	if err != nil {