Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gerrit Sign Flow Update #4359

Open
nickmango opened this issue Jun 12, 2024 · 3 comments
Open

Gerrit Sign Flow Update #4359

nickmango opened this issue Jun 12, 2024 · 3 comments
Assignees
@nickmango
Labels
enhancement New feature or request ldap

Comments

@nickmango
Copy link
Collaborator

Summary

A user that has successfully signed and got authorized should not be added an LDAP group

User Story

  • As a developer, I want to be able to complete the cla sign process (icla,ccla,ecla) without the need to be added an LDAP group, such that the decomissioning of LDAP is not dependent on Easycla sign flow

Acceptance Criteria

  1. Upon signing the user should not have been added to an LDAP group assocaited with the claGroup
@nickmango nickmango added the enhancement New feature or request label Jun 12, 2024
@nickmango nickmango self-assigned this Jun 12, 2024
nickmango added a commit to nickmango/easycla that referenced this issue Jun 17, 2024
@nickmango
[communitybridge#4358,communitybridge#4359] Feature/LDAP Decommissioning
f8b063a 
- Removed LDAP group endpoints (icla,ecla)
- Updated gerrit onboarding API input with no icla &&& ccla group IDs
- Updated signed handlers to remove ldap group additions on signing
- Updated approval list handling of gerrit users (TODO - update a new way of handling users)

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Jun 17, 2024
@nickmango
Merge pull request #4361 from nickmango/feature/ldap-decommision-onboard
e23761e 
[#4358,#4359] Feature/LDAP Decommissioning
@nickmango
Copy link
Collaborator Author

@thakurveerendras This involves LDAP groups not getting added/removed . Currently not possible to verify this in dev
cc @mlehotskylf

nickmango added a commit that referenced this issue Jul 4, 2024
@nickmango
Revert "[#4358,#4359] Feature/LDAP Decommissioning"
60732ae
nickmango added a commit to nickmango/easycla that referenced this issue Jul 4, 2024
@nickmango
Revert "[communitybridge#4358,communitybridge#4359] Feature/LDAP Deco…
a88ed81 
…mmissioning"

This reverts commit f8b063a.
nickmango added a commit that referenced this issue Jul 4, 2024
@nickmango
Merge pull request #4372 from nickmango/revert-ldap
3a1ccd6 
Revert "[#4358,#4359] Feature/LDAP Decommissioning"
nickmango added a commit to nickmango/easycla that referenced this issue Jul 9, 2024
@nickmango
Revert "Revert "[communitybridge#4358,communitybridge#4359] Feature/L…
558ac26 
…DAP Decommissioning""

This reverts commit a88ed81.
nickmango added a commit that referenced this issue Jul 9, 2024
@nickmango
Merge pull request #4376 from nickmango/unrevert-ldap
d9d5d64 
Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 11, 2024
@nickmango
Revert "Revert "Revert "[communitybridge#4358,communitybridge#4359] F…
74912ee 
…eature/LDAP Decommissioning"""

This reverts commit 558ac26.
nickmango added a commit that referenced this issue Jul 11, 2024
@nickmango
Merge pull request #4383 from nickmango/feature/gerrit-ldap-rev
c3df585 
Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning"""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 16, 2024
@nickmango
Revert "Revert "Revert "Revert "[communitybridge#4358,communitybridge…
db87d07 
…#4359] Feature/LDAP Decommissioning""""

This reverts commit 74912ee.
nickmango added a commit that referenced this issue Jul 16, 2024
@nickmango
Merge pull request #4388 from nickmango/ldap-unrevert
a766ca4 
Revert "Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommiss"""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 17, 2024
@nickmango
Revert "Revert "Revert "Revert "Revert "[communitybridge#4358,communi…
31f3a80 
…tybridge#4359] Feature/LDAP Decommissioning"

This reverts commit db87d07.
nickmango added a commit that referenced this issue Jul 17, 2024
@nickmango
Merge pull request #4390 from nickmango/feature/revery-ldap
739f57b 
Revert "Revert "Revert "Revert "Revert "[#4358,#4359] Feature/LDAP"
nickmango added a commit to nickmango/easycla that referenced this issue Jul 18, 2024
@nickmango
Revert "[communitybridge#4358,communitybridge#4359] Feature/LDAP Deco…
e6515cf 
…mmissioning"

This reverts commit 31f3a80.
nickmango added a commit that referenced this issue Jul 18, 2024
@nickmango
Merge pull request #4391 from nickmango/unrevert-ldap-fix
2e175d6 
Revert "[#4358,#4359] Feature/LDAP Decommissioning"
nickmango added a commit to nickmango/easycla that referenced this issue Jul 30, 2024
@nickmango
Revert "Revert "[communitybridge#4358,communitybridge#4359] Feature/L…
732488e 
…DAP Decommissioning""

This reverts commit e6515cf.
nickmango added a commit that referenced this issue Jul 30, 2024
@nickmango
Merge pull request #4397 from nickmango/revert-gerrit-ldap
5a7c99c 
Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning""
nickmango added a commit to nickmango/easycla that referenced this issue Jul 30, 2024
@nickmango
Revert "Revert "[communitybridge#4358,communitybridge#4359] Feature/L…
7cf64fa 
…DAP Decommissioning""

This reverts commit e6515cf.

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit to nickmango/easycla that referenced this issue Aug 2, 2024
@nickmango
Revert "Revert "Revert "[communitybridge#4358,communitybridge#4359] F…
4d37c4d 
…eature/LDAP Decommissioning"""

This reverts commit 732488e.
nickmango added a commit that referenced this issue Aug 2, 2024
@nickmango
Merge pull request #4399 from nickmango/revert-ldap-ids
2825fb4 
Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommissioning"""
nickmango added a commit to nickmango/easycla that referenced this issue Aug 13, 2024
@nickmango
Revert "Revert "Revert "Revert "[communitybridge#4358,communitybridge…
acc995b 
…#4359] Feature/LDAP Decommissioning""""

This reverts commit 4d37c4d.
nickmango added a commit to nickmango/easycla that referenced this issue Aug 13, 2024
@nickmango
Revert "Revert "Revert "Revert "[communitybridge#4358,communitybridge…
74f4f6d 
…#4359] Feature/LDAP Decommissioning""""

This reverts commit 4d37c4d.

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Aug 13, 2024
@nickmango
Merge pull request #4409 from nickmango/revert-ldap-gerrit
bc09d73 
Revert "Revert "Revert "Revert "[#4358,#4359] Feature/LDAP Decommissi…
nickmango added a commit to nickmango/easycla that referenced this issue Aug 21, 2024
@nickmango
Revert "Revert "Revert "Revert "Revert "[communitybridge#4358,communi…
0e932be 
…tybridge#4359] Feature/LDAP Decommissioning"""""

This reverts commit 74f4f6d.
nickmango added a commit to nickmango/easycla that referenced this issue Aug 22, 2024
@nickmango
Revert "Revert "Revert "Revert "Revert "[communitybridge#4358,communi…
77aa676 
…tybridge#4359] Feature/LDAP Decommissioning"""""

This reverts commit 74f4f6d.
nickmango added a commit to nickmango/easycla that referenced this issue Aug 22, 2024
@nickmango
Revert "Revert "Revert "Revert "Revert "[communitybridge#4358,communi…
d6e75fb 
…tybridge#4359] Feature/LDAP Decommissioning"""""

This reverts commit 74f4f6d.
@lukaszgryglicki
Copy link
Contributor

As we talked on KT3 - can we have a dev gerrit server instance?

@nickmango
Copy link
Collaborator Author

nickmango commented Dec 5, 2024 •
edited
Loading

@lukaszgryglicki theres a task for this on #4348

  1. Investigate SSO (SAML) support for ITX Gerrit test instance (which lives in ITX DEV) - create client, etc Jordan Evans - ticket is here. There was a ticket for this on his end
    This was done and a mock server for testing was provisioned for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickmango nickmango

Labels
enhancement New feature or request ldap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukaszgryglicki @mlehotskylf @nickmango