Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonsApplication migrate to kotlin & some lint fixes #5879

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CommonsApplication migrate to kotlin & some lint fixes #5879

wants to merge 7 commits into from

Commits on Oct 24, 2024

  1. convert to kotlin 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    eb23d32 View commit details
    Browse the repository at this point in the history

  2. use lateinit instead of nullable types 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    da398a1 View commit details
    Browse the repository at this point in the history

  3. instance property access fix 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    45c49b2 View commit details
    Browse the repository at this point in the history

  4. refactor constants name with uppercased ones 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0439370 View commit details
    Browse the repository at this point in the history

  5. remove unused 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    26b9d0e View commit details
    Browse the repository at this point in the history

  6. fix imports in test 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2e4b66a View commit details
    Browse the repository at this point in the history

  7. use mockk for kotlin to fix tests 

    Signed-off-by: parneet-guraya <[email protected]>
    @parneet-guraya
    parneet-guraya committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d925e44 View commit details
    Browse the repository at this point in the history