-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CommonsApplication
migrate to kotlin & some lint fixes
#5879
base: main
Are you sure you want to change the base?
CommonsApplication
migrate to kotlin & some lint fixes
#5879
Conversation
CI failing due to some unit test. Will fix it |
I did a few uploads and tried most activities of the app with this branch. It works as usual. :-) |
Actually just one test failing due to |
0e8e93a
to
d665188
Compare
This test was causing the issue apps-android-commons/app/src/test/kotlin/fr/free/nrw/commons/actions/ThanksClientTest.kt Line 42 in f1205c1
Most likely this is library issue. Also, from my research on stackoverflow mocking statics is discouraged. Also I found out So, at the end I refactored the function to take application as an argument rather calling it inside. |
Thanks! Would you mind fixing the conflict? |
d665188
to
b22ffe4
Compare
Done |
Waiting for this one #5887 |
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
Signed-off-by: parneet-guraya <[email protected]>
b22ffe4
to
d925e44
Compare
From comment
What changes did you make and why?
Tests performed (required)
tested
betaDebug
&prodDebug
on Oneplus 9RT 5G , Android 14