Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub API URL to support arbitrary default branches for templates #5447

Merged
merged 1 commit into from
Dec 5, 2020
Merged

GitHub API URL to support arbitrary default branches for templates #5447

merged 1 commit into from
Dec 5, 2020

Conversation

qrilka
Copy link
Contributor

@qrilka qrilka commented Dec 1, 2020 •
edited
Loading

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Resolves #5422
Tested manually

@qrilka qrilka mentioned this pull request Dec 1, 2020
Closed
@qrilka qrilka force-pushed the 5422-tpl-support-other-default-github-branches branch 2 times, most recently from 177f3bb to 3eb20ba Compare December 2, 2020 06:46
@qrilka qrilka force-pushed the 5422-tpl-support-other-default-github-branches branch from 3eb20ba to 455e98f Compare December 4, 2020 12:37
@qrilka qrilka marked this pull request as ready for review December 4, 2020 12:37
@qrilka qrilka requested a review from snoyberg December 4, 2020 12:37
@qrilka
Copy link
Contributor Author

qrilka commented Dec 4, 2020

The error on macOS appears to be rate limit exceeded from GitHub and not related to the PR itself

snoyberg
snoyberg approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snoyberg snoyberg merged commit 4cbcac7 into master Dec 5, 2020
@snoyberg snoyberg deleted the 5422-tpl-support-other-default-github-branches branch December 5, 2020 15:57
@matsubara0507 matsubara0507 mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support main as the default branch for templates
2 participants
@qrilka @snoyberg