Parse .dump-hi files of library components only once #2658
Conversation
|
With this change a null build of the amazonka project (78 packages) takes ~14s on my machine vs. ~22s with v1.2.0. |
| @@ -734,14 +734,14 @@ libraryFiles lib = do | |||
| resolveFilesAndDeps | |||
| Nothing | |||
| (dirs ++ [dir]) | |||
| (names <> exposed) | |||
| names | |||
There was a problem hiding this comment.
This line alone would be a sufficient fix (see names = bnames ++ exposed!) but I felt that Set is the better datastructure than [] in this case. Order isn't doesn't seem to be important and we don't want any duplicates.
I actually think that we should use Set instead of [] much more pervasively to prevent ourselves from wondering whether duplicates and order actually matter in each case.
There was a problem hiding this comment.
My reasoning for not having it be a Set is that there is cost to constructing the Set, and we always convert it from / to a list. It is semantically more correct, though, indeed!
|
I am fine with the use of Set, but are you sure it's worth it? Seems to me like it's just extra work at runtime. It does encode more invariants (no duplicates), but I it will cost some performance for construction / enumeration. Why not just keep it lists? |
sjakobi
force-pushed
the
less-dump-hi-parsing
branch
from
4ea9fbf to
28b012e
Compare
This fixes a performance regression introduced in 5f3ffe5.
sjakobi
force-pushed
the
less-dump-hi-parsing
branch
from
28b012e to
fe20f8d
Compare
|
I have undone the switch to |
|
Thanks, glad this is fixed! :D |
This fixes a performance regression introduced in 5f3ffe5.