Parse .dump-hi files of library components only once

This fixes a performance regression introduced in 5f3ffe5.
commercialhaskell · Oct 3, 2016 · 8997b11 · 8997b11
1 parent 2caa052
commit 8997b11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -54,6 +54,9 @@ Bug fixes:
   [#2568](https://github.com/commercialhaskell/stack/issues/2568)
 * Fixed running `stack hpc report` on package targets.
   [#2664](https://github.com/commercialhaskell/stack/issues/2664)
+* Fix a long-standing performance regression where stack would parse the .dump-hi
+  files of the library components of local packages twice.
+  [#2658](https://github.com/commercialhaskell/stack/pull/2658)
 
 ## 1.2.0
 

diff --git a/src/Stack/Package.hs b/src/Stack/Package.hs
@@ -734,7 +734,7 @@ libraryFiles lib = do
         resolveFilesAndDeps
             Nothing
             (dirs ++ [dir])
-            (names <> exposed)
+            names
             haskellModuleExts
     cfiles <- buildOtherSources build
     return (modules, files <> cfiles, warnings)