Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the --os flag. #2477

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Remove the --os flag. #2477

merged 2 commits into from
Aug 12, 2016

Conversation

0xmohit
Copy link
Contributor

@0xmohit 0xmohit commented Aug 11, 2016

Fixes #2227

@sjakobi
Copy link
Member

sjakobi commented Aug 11, 2016

Thanks for working on this!

Can you add an entry to the changelog and check if there's any documentation that needs to be changed or removed?

@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 11, 2016

Added a ChangeLog entry (wasn't familiar with it's existence). Will look into the docs to determine if anything else needs to change.

@sjakobi
Copy link
Member

sjakobi commented Aug 11, 2016

No worries about the AppVeyor failure BTW, that's caused by #2457.

@0xmohit
Copy link
Contributor Author

0xmohit commented Aug 12, 2016

Unable to find any reference to --os in the docs, so I suspect there's nothing else to change here.

@mgsloan mgsloan merged commit 0bc1927 into commercialhaskell:master Aug 12, 2016
@0xmohit 0xmohit deleted the remove_os_flag branch August 12, 2016 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmohit @sjakobi @mgsloan