-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for rendering GHCi scripts targeting different GHCi like applications. #2457
Adding support for rendering GHCi scripts targeting different GHCi like applications. #2457
Conversation
Tests that a module can be added multiple times in a GHCi script.
Adding support for rendering GHCi scripts targeting different GHCi like applications.
LGTM! |
Thanks for the PR, but src/test/Stack/Ghci/ScriptSpec.hs and src/test/Stack/GhciSpec.hs fail on Windows by introducing failures in Template Haskell code. |
@Blaisorblade, what errors does it create, and what would I need in order to reproduce them? |
From https://ci.appveyor.com/project/snoyberg/stack/build/1.0.2040, looks like
Surprising to me, considering that msys and such pretends to have a |
@mgsloan I understand I have to use @AndrewRademacher To fix it, I'd imagine one would to replace all "/" with </>, both in the paths (to fix compilation) and in the test results, make it compile again on your platform, and hope it still works on the CI. I understand this is annoying... maybe @mgsloan has a Windows machine? :-( And, sorry for asking, but are you familiar with AppVeyor and the red cross in GitHub's UI next to your commits in this PR? Clicking on it leads to the logs from continuous integrations (that is, build servers); Appveyor tests on Windows, Travis on other OSs (and @mgsloan already fixed the Travis failures). |
Yeah, my mistake, should've gotten all CI results before merging. |
@Blaisorblade, I actually didn't think that this error happened in the CI. @mgsloan and I had a conversation earlier about the errors that I had produced, so I falsely assumed that the error you were talking about was in addition to what happened in CI. On the bright side, I have boot camped my Mac. So I can reproduce on my windows machine. |
@AndrewRademacher Ah that explains it. Please take no offense at the useless explanation, I should have just mentioned CI in my message! |
@AndrewRademacher Any progress? I'm working on this right now. I've just learned that mkAbs* fails because "/a/b" is recognized as a relative path on Windows:
/cc @mgsloan. |
@Blaisorblade, looks like I have a lot of work to do this weekend. |
@AndrewRademacher That's OK; I've now fixed the paths problem. (Actually I should have asked before starting, sorry about that; I inferred you lacked the time). |
To this end, define WINDOWS also in testsuite.
This PR adds the capacity to StackGhci to render GHCi scripts for different targets like Intero. Or for differing versions of GHCi. Additionally, this takes advantage of setting the current working directory in Intero when available.
This is all aimed at supporting the loading of multiple packages simultaneously in a REPL.