Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix completely #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove prefix completely #17

wants to merge 5 commits into from

Conversation

drozzy
Copy link

@drozzy drozzy commented Sep 8, 2018

I got rid of the prefix, replacing it with the $streams stream. This works for loading aggregates pretty well, which is all I really need. Allows me to do projections in Greg's EventStore correctly (e.g. by using $ce-aggregatename):

screen shot 2018-09-08 at 7 08 26 pm

Did not test:

  • event handlers
  • process managers

@drozzy
Copy link
Author

drozzy commented Sep 9, 2018

This certainly breaks tests.. not sure how to fix them. E.g.:

5) test subscribe to all streams should receive events appended to any stream (Commanded.EventStore.Adapter.SubscriptionTest)
     deps/commanded/test/event_store_adapter/subscription_test.exs:105
     No message matching {:events, received_events} after 5000ms.
     The process mailbox is empty.

@drozzy
Copy link
Author

drozzy commented Sep 9, 2018

I also added a fix that set the extreme dep to ~> 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant