Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract subscribe_to_stream function #13

Closed
wants to merge 3 commits into from

Conversation

jfornoff
Copy link
Contributor

The only persistent subscription functionality is currently subscribing
to all streams. We can allow subscribing to arbitrary streams by
extracting a function that takes the stream name as an argument.

So this is just an extract function refactoring :-)

The only persistent subscription functionality is currently subscribing
to all streams. We can allow subscribing to arbitrary streams by
extracting a function that takes the stream name as an argument.
To match naming in commanded/eventstore
@jfornoff jfornoff changed the title Extract persistent_subscribe function Extract subscribe_to_stream function Jun 1, 2018
@drozzy
Copy link

drozzy commented Sep 8, 2018

I suggest you use $streams here instead. Not sure what the "" will actually accomplish...

@drozzy
Copy link

drozzy commented Sep 8, 2018

In my PR I removed this completely and replaced it with $streams:
#17

Not sure what it affects, but I verified that aggregate loading/saving works correctly.

@jfornoff
Copy link
Contributor Author

jfornoff commented Sep 9, 2018

This PR is intended to be a refactoring, so I did not change any behavior.
@drozzy I'm pretty sure if you do not listen to $all that it probably breaks strong consistency (from what I gather) -- at least if you don't specify which handlers you are specifically waiting for and just set strong_consistency: :true.

@drozzy
Copy link

drozzy commented Sep 10, 2018

Not sure what you mean by strong consistency. If we assume that one aggregate is one stream - there is no need for inter-aggregate consistency, since aggregate is the only consistency boundary in DDD...
Unless I'm misunderstanding something.

@jfornoff
Copy link
Contributor Author

I mean this. Its not about aggregates, but event handlers.

@drozzy
Copy link

drozzy commented Sep 11, 2018

Not sure how you can ensure that all event handlers processed an event... What if the event handler is not using commanded, but rather subscribes directly to EventStore, via Extreme or even .NET?

@jfornoff
Copy link
Contributor Author

It doesn't work if it is not using Commanded, pretty sure.

@jfornoff jfornoff closed this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants