-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract subscribe_to_stream function #13
Conversation
The only persistent subscription functionality is currently subscribing to all streams. We can allow subscribing to arbitrary streams by extracting a function that takes the stream name as an argument.
To match naming in commanded/eventstore
I suggest you use |
In my PR I removed this completely and replaced it with Not sure what it affects, but I verified that aggregate loading/saving works correctly. |
This PR is intended to be a refactoring, so I did not change any behavior. |
Not sure what you mean by strong consistency. If we assume that one aggregate is one stream - there is no need for inter-aggregate consistency, since aggregate is the only consistency boundary in DDD... |
I mean this. Its not about aggregates, but event handlers. |
Not sure how you can ensure that all event handlers processed an event... What if the event handler is not using commanded, but rather subscribes directly to EventStore, via Extreme or even .NET? |
It doesn't work if it is not using Commanded, pretty sure. |
The only persistent subscription functionality is currently subscribing
to all streams. We can allow subscribing to arbitrary streams by
extracting a function that takes the stream name as an argument.
So this is just an extract function refactoring :-)