VW MLB: Audi A4/S4 #793
VW MLB: Audi A4/S4 #793
Conversation
jyoung8607
commented
Mar 15, 2023
•
jyoung8607
commented
- support MLB CRCs, some for new messages and some conflict/overlap with existing messages
| @@ -108,7 +108,7 @@ void init_crc_lookup_tables() { | |||
| gen_crc_lookup_table_16(0x1021, crc16_lut_xmodem); // CRC-16 XMODEM for HKG CAN FD | |||
| } | |||
|
|
|||
| unsigned int volkswagen_mqb_checksum(uint32_t address, const Signal &sig, const std::vector<uint8_t> &d) { | |||
| unsigned int volkswagen_mxb_checksum(uint32_t address, const Signal &sig, const std::vector<uint8_t> &d) { | |||
There was a problem hiding this comment.
what do you think of mxb -> mqb_mlb for better grep-ability?
There was a problem hiding this comment.
I'm okay with either. The whole set of abstractions needs another look, was focused on passing tests tonight, will look at it with fresh eyes later.
|
@jyoung8607 I am interested in this PR, how is it going? |
Started to reply, and it turned into a general update which I put in the openpilot PR. Let me know if you have other questions, or if you have a supportable vehicle and would like to help. |
I do not actually use openpilot at all, my only interest is the nice DBC which is part of this larger change here. Thus #1008 as an attempt to help with just the DBC merge. |
