cherry pick of VW MLB: Audi A4/S4 DBC #1008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what this is for. |
this is me trying to decouple the DBC part of the https://github.com/commaai/opendbc/pull/793/commits change from the rest of the stale? abandoned? PR in order to get this DBC merged into https://github.com/commaai/opendbc/ sooner rather than later. |
|
@jyoung8607 is it safe to merge just the DBC file like in this PR? Any reasons not to move forward with just the DBC while the rest of the #793 change is still a draft? |
|
It's not ready for review yet. |
|
Could U pls consider sorting by message ID. It makes easier search and reading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick of only DBC commit of #793